Skip to content

fix(OSQUERY-001): CU-86akhf8u2 kernel_keys integration test performs no validation of query results #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
flamingo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(OSQUERY-001): CU-86akhf8u2 kernel_keys integration test performs no validation of query results #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tests/integration/tables/kernel_keys.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@ class KernelKeys : public testing::Test {

TEST_F(KernelKeys, test_sanity) {

@flamingo flamingo Bot Sep 21, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🔴 kernel_keys integration test performs no validation of query results

In TEST_F(KernelKeys, test_sanity) in tests/integration/tables/kernel_keys.cpp, added a ValidationMap (row_map) with columns "serial_number" (NonEmptyString) and "description" (NormalType) and a call to validate_rows(data, row_map), matching the ValidationMap + validate_rows() pattern from interface_ipv6.cpp/kernel_info.cpp. Risk: the exact column names/types for the kernel_keys table were not visible in the provided material; these were taken directly from the finding's suggested fix, so if the actual table spec uses different column names or types this validation could fail at runtime and would need adjustment against specs/linux/kernel_keys.table.

🤖 Prompt for AI agents 
In tests/integration/tables/kernel_keys.cpp around line 25, review and complete this code-review fix: kernel_keys integration test performs no validation of query results.
What the draft fix changed: In TEST_F(KernelKeys, test_sanity) in tests/integration/tables/kernel_keys.cpp, added a ValidationMap (row_map) with columns "serial_number" (NonEmptyString) and "description" (NormalType) and a call to validate_rows(data, row_map), matching the ValidationMap + validate_rows() pattern from interface_ipv6.cpp/kernel_info.cpp. Risk: the exact column names/types for the kernel_keys table were not visible in the provided material; these were taken directly from the finding's suggested fix, so if the actual table spec uses different column names or types this validation could fail at runtime and would need adjustment against specs/linux/kernel_keys.table.
Verify the change is correct and complete; do not refactor unrelated code.

fix confidence: 🟡 70 medium — react 👍/👎 to teach the reviewer

QueryData data = execute_query("select * from kernel_keys");
ValidationMap row_map = {
{"serial_number", NonEmptyString},
{"description", NormalType},
};
validate_rows(data, row_map);
}

} // namespace table_tests
} // namespace osquery

Loading