fix(OPENFRAM-002-6): CU-86akn96pf OAuthToken lacks the full Lombok quartet required for @Document classes - #2426
Draft
flamingo[bot] wants to merge 1 commit into
Draft
flamingo[bot] wants to merge 1 commit into
flamingo[bot] wants to merge 1 commit into
Conversation
| import org.springframework.data.mongodb.core.index.Indexed; | ||
| import org.springframework.data.mongodb.core.mapping.Document; | ||
| import java.time.Instant; | ||
| @Data |
Contributor
Author
There was a problem hiding this comment.
🦩 🟠 OAuthToken lacks the full Lombok quartet required for @document classes
Added @Builder, @NoArgsConstructor, and @AllArgsConstructor annotations (with corresponding lombok imports) to the OAuthToken class in openframe-data-mongo-common/src/main/java/com/openframe/data/document/oauth/OAuthToken.java, alongside the existing @Data and @Document annotations, completing the required Lombok quartet.
🤖 Prompt for AI agents
In openframe-data-mongo-common/src/main/java/com/openframe/data/document/oauth/OAuthToken.java around line 8, review and complete this code-review fix: OAuthToken lacks the full Lombok quartet required for @Document classes.
What the draft fix changed: Added `@Builder`, `@NoArgsConstructor`, and `@AllArgsConstructor` annotations (with corresponding lombok imports) to the `OAuthToken` class in `openframe-data-mongo-common/src/main/java/com/openframe/data/document/oauth/OAuthToken.java`, alongside the existing `@Data` and `@Document` annotations, completing the required Lombok quartet.
Verify the change is correct and complete; do not refactor unrelated code.
fix confidence: 🟢 92 high — react 👍/👎 to teach the reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes findings from rule OPENFRAM-002-6 — OAuthToken lacks the full Lombok quartet required for @document classes.
Draft — this is a starting point, not a finished change. The fix required judgment, so read it before trusting it.
openframe-data-mongo-common/src/main/java/com/openframe/data/document/oauth/OAuthToken.java:8What changed — and what was deliberately left — is explained per finding as inline review comments on the lines each finding touched.
Run: https://product-hub.flamingo.so/admin/code-review
Run id:
9a25c19f-a499-4571-bb37-da3cba9b8394Merging this PR is recorded as acceptance of the rule that produced it;
closing it unmerged is recorded as rejection. Both feed rule health, so
closing a wrong suggestion is useful rather than merely tidy.
ClickUp task: CU-86akn96pf OpenFrame lib batch review findings sweep (7 PRs)