refactor(delivery): engine publishes, specs only name the subject - #2388
Merged
Merged
Conversation
Kirill's review note: every spec would repeat the same NATS publish. DeliverySpec.publish(machineId, payload) becomes subject(machineId); DeliveryDispatcher and DeliverySweepService publish through the new DeliveryPublisher, implemented over NatsMessagePublisher in data-nats. Wire bytes unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SnaktPhqs3aeuuUHdXCAjX
Contributor
🦩 Flamingo Code Review2 finding(s) — 0 action required · 2 recommended · 0 informational Mode: advisory · Rules cited: Inline comments: 2 new Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-09-25 09:11 UTC · updated 2026-09-25 09:12 UTC · workflow run |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yevhenii-flamingo
approved these changes
Sep 25, 2026
kirill-567
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2212, from Kirill's note: every spec would carry the same NATS publish, so move it into the engine.
DeliverySpec.publish(machineId, payload)→subject(machineId). A spec now only builds the payload and names the subject.DeliveryPublisherin the engine;NatsDeliveryPublisher(data-nats) implements it overNatsMessagePublisher.publish(core NATS, same as before).DeliveryDispatcherandDeliverySweepServicepublish viaDeliveryPublisher. The dispatcher takes it throughObjectProvider, because the dispatcher bean also exists in services without NATS.Wire bytes and subjects are unchanged:
machine.{id}.tool-installation, same payload. No config changes.Tests: machine-delivery 50, data-nats 77, client-core 225, api-service-core 466 — all green locally.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SnaktPhqs3aeuuUHdXCAjX