fix(redis): ask INFO, not CLUSTER INFO, whether this is a cluster - #2352
Merged
Merged
Conversation
cluster_enabled lives in INFO's Cluster section. CLUSTER INFO reports the state
of a cluster — cluster_state, cluster_slots_*, cluster_known_nodes — and never
carries cluster_enabled, so `clusterInfo().contains("cluster_enabled:1")` is
false against every server there is.
The failure is one-sided and silent. On dev and qa, single-node Memorystore, the
wrong answer is the right one and everything passed. On production's six-node
cluster the probe reported "cluster mode disabled", getResetToken took the
standalone branch, and the first MGET came back
JedisMovedDataException: MOVED 4478 redis-cluster-4.internal.openframe.ai:6379
46 times over the 90s poll, which the rotator reports as a missing token. That
took the production tenant report down on the 16:00 run of 2026-09-23 — the
first run after 6.36.10 rolled out — and it would have taken every later run
with it.
Behaviour where the probe cannot connect is unchanged: assume a cluster for that
one lookup, remember nothing. RedisConfig.getConfiguredCluster() still wins, and
configs/prod pins cluster: true so production does not wait on this release.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
🦩 Flamingo Code ReviewNo findings on the current head. Mode: advisory Need another pass? Commits pushed after this review are not reviewed automatically.
Prefer typing? Comment React 👍/👎 on inline comments to teach the reviewer. Started 2026-09-23 16:41 UTC · updated 2026-09-23 16:41 UTC · workflow run |
giokur
enabled auto-merge (squash)
September 23, 2026 16:43
mikhail-nosan
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cluster_enabledlives inINFO's Cluster section.CLUSTER INFOreports the state of acluster —
cluster_state,cluster_slots_assigned,cluster_known_nodes— and never carriescluster_enabled. So the probe added in #2348always answered "not a cluster".
Why it got through
The wrong answer is the right answer on a single node. dev and qa are single-node Memorystore, so the
probe looked correct there and the password-reset lookup kept working.
Production is a six-node cluster. There,
clusterMode()returned false,getResetTokentook thestandalone branch,
SCANran against one seed and the firstMGETcame back:46 times across the rotator's 90-second poll, which surfaces as
No password-reset token for test@flamingo.cx appeared within 90s (46 scans). The production tenant report failed its 16:00 run on2026-09-23 — the first after 6.36.10 rolled out — and every later run would have failed the same way.
Production keeps no fallback password for that account by design, so a failed rotation stops the report
entirely rather than degrading it.
The prod log line that names the bug outright:
against a server that answers MOVED. That is the probe calling a live cluster a single node.
The fix
jedis.info("cluster"), whose Cluster section is wherecluster_enabledactually is.Everything else is unchanged: a probe that cannot connect still assumes a cluster for that one lookup
and remembers nothing, and
RedisConfig.getConfiguredCluster()still wins.Compiles.
Ships with saas-shared, which pins
test.redis.cluster: trueinconfigs/prodso production isrestored at its next config refresh rather than waiting on this release, the pin bump and a rollout.
That pin can come out once this is deployed.
🤖 Generated with Claude Code