Skip to content

fix(OPENFRAM-007-2): CU-86akhf8u5 2 review findings in layout.tsx #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flamingo wants to merge 1 commit into from
Closed

fix(OPENFRAM-007-2): CU-86akhf8u5 2 review findings in layout.tsx #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import { RegistrationAttributionCapture } from './components/registration-attrib
import { TokenFreshnessWatcher } from './components/token-freshness-watcher';

export const metadata: Metadata = {
metadataBase: new URL(process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai'),

@flamingo flamingo Bot Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 Direct process.env.NEXT_PUBLIC_APP_URL reads bypass the runtimeEnv abstraction

Replaced new URL(process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai') in metadata.metadataBase with new URL(runtimeEnv.appUrl()) in src/app/layout.tsx. This assumes runtimeEnv.appUrl() exists (or will be added) on the runtimeEnv object exported from src/lib/runtime-config.ts and returns a string with the same fallback ('https://openframe.ai') baked in; since I cannot see/edit that file in this task, this accessor must be added there for the build to compile — without it this is a broken import member, not a working fix.

🤖 Prompt for AI agents 
In src/app/layout.tsx around line 29, review and complete this code-review fix: Direct process.env.NEXT_PUBLIC_APP_URL reads bypass the runtimeEnv abstraction.
What the draft fix changed: Replaced `new URL(process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai')` in `metadata.metadataBase` with `new URL(runtimeEnv.appUrl())` in src/app/layout.tsx. This assumes `runtimeEnv.appUrl()` exists (or will be added) on the `runtimeEnv` object exported from src/lib/runtime-config.ts and returns a string with the same fallback ('https://openframe.ai') baked in; since I cannot see/edit that file in this task, this accessor must be added there for the build to compile — without it this is a broken import member, not a working fix.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 40 low — review closely — react 👍/👎 to teach the reviewer

metadataBase: new URL(runtimeEnv.appUrl()),

title: {
default: 'OpenFrame - AI-Driven Open-Source OS for MSPs',
Expand All @@ -41,7 +41,7 @@ export const metadata: Metadata = {
openGraph: {
type: 'website',
locale: 'en_US',
url: process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai',

@flamingo flamingo Bot Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦩 🟠 Direct process.env.NEXT_PUBLIC_APP_URL read in openGraph.url bypasses runtimeEnv

Replaced process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai' in metadata.openGraph.url with runtimeEnv.appUrl() in src/app/layout.tsx, same mechanism and same caveat as finding 1: it depends on runtimeEnv.appUrl() being implemented in src/lib/runtime-config.ts with equivalent fallback semantics, which is outside this file and not verified here.

🤖 Prompt for AI agents 
In src/app/layout.tsx around line 44, review and complete this code-review fix: Direct process.env.NEXT_PUBLIC_APP_URL read in openGraph.url bypasses runtimeEnv.
What the draft fix changed: Replaced `process.env.NEXT_PUBLIC_APP_URL || 'https://openframe.ai'` in `metadata.openGraph.url` with `runtimeEnv.appUrl()` in src/app/layout.tsx, same mechanism and same caveat as finding 1: it depends on `runtimeEnv.appUrl()` being implemented in src/lib/runtime-config.ts with equivalent fallback semantics, which is outside this file and not verified here.
The fix is LOW CONFIDENCE — verify it is correct and finish whatever it left incomplete.

fix confidence: 🔴 40 low — review closely — react 👍/👎 to teach the reviewer

url: runtimeEnv.appUrl(),
siteName: 'OpenFrame',
title: 'OpenFrame - AI-Driven Open-Source OS for MSPs',
description:
Expand Down
Loading