Repository navigation
Tickets: lock status changes while an approval request is pending - #280
Merged
romanivan-flamingo merged 11 commits intoSep 24, 2026
Merged
Conversation
A Tech Required ticket with a pending tool-approval request cannot change status - the server rejects every transition (409, openframe-saas-tenant#2764) and returns empty availableTransitions. Mirror the lock in the UI instead of letting users hit the error: - detail page: the inline status changer renders as a locked tag with the reason in a tooltip; handleTransition guards the programmatic path; the cached ticket refetches right after approve/reject so the lock releases - board: dragging a locked card out of its lane toasts the reason and snaps back; the Take Over trigger on the assignee avatar toasts instead of opening the modal (the board fragment now selects statusDefinition.kind) - take-over: openTakeOver has a safety-net guard, and both Start Direct Chat buttons disable with the tooltip while the AI still works a locked ticket - edit form: the status field disables with the tooltip The lock signal is Ticket.pendingApproval (now selected by GET_TICKET_QUERY), which uses the same pending semantics as the server-side lock. Requires @flamingo-stack/openframe-frontend-core with TicketStatusTag disabled/disabledReason (openframe-oss-lib#1898) - version bump follows the lib release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Brings TicketStatusTag disabled/disabledReason and the TicketInfoSection pass-through for the pending-approval status lock (openframe-oss-lib#1898). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
romanivan-flamingo
marked this pull request as ready for review
August 24, 2026 14:30
…dicate The drop interception checked statusDefinition kind + pendingApproval directly; isStatusLockedByPendingApproval is the single definition of the lock and works on board dialogs since the fragment selects the kind. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aliaska-varieva
previously approved these changes
Aug 24, 2026
pavlo-flamingo
previously approved these changes
Aug 24, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
romanivan-flamingo
dismissed stale reviews from pavlo-flamingo and aliaska-varieva
via
August 24, 2026 17:53
9d8aac2
romanivan-flamingo
enabled auto-merge (squash)
August 25, 2026 12:29
romanivan-flamingo
disabled auto-merge
August 25, 2026 12:29
Conflict resolutions for the month of tickets-domain drift: - tickets-board: dropped the branch's avatar Take Over toast - main removed the avatar take-over flow entirely (plain assign is not a status change, so the lock does not apply); the drag guard stays ahead of the new heldMove interceptions - ticket-details-view: the old two-panel layout block went away with the redesign; the lock survives in the InfoSection status row, the handleTransition/openTakeOver guards, and the Start Direct Chat tooltip in the new clientChatBody - ticket-form-fields: kept the status-lock field disable alongside main's useWatch migration Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… redesign hasActiveAiDialog now means statusKind AI_ASSISTANCE only (86ak573q9), and a locked ticket is always Tech Required - the openTakeOver guard and the Start Direct Chat disable could never fire. Starting a direct chat on a locked ticket is correct anyway: it changes no status, and the handoff cancels the pending approval server-side, which unlocks the ticket by design. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
romanivan-flamingo
enabled auto-merge (squash)
September 24, 2026 14:00
aliaska-varieva
approved these changes
Sep 24, 2026
romanivan-flamingo
deleted the
hotfix/ticket-status-lock-pending-approval
branch
September 24, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FE part of ClickUp 86ajqa7bv: a Tech Required ticket with a pending tool-approval request cannot change status. The server enforces the lock (openframe-saas-tenant#2764: 409
TICKET_STATUS_LOCKED_PENDING_APPROVAL, emptyavailableTransitions); this PR mirrors it in the UI so users see the reason instead of hitting the error.handleTransitionguards the programmatic path; the ticket refetches right after approve/reject so the lock releases immediately.statusDefinition.kind.openTakeOverhas a safety-net guard, both Start Direct Chat buttons disable with the tooltip while the AI still works a locked ticket.Ticket.pendingApproval(added toGET_TICKET_QUERY; same pending semantics as the server-side lock - escalate-to-human offers excluded).