Skip to content

Use Selenium’s default session request timeout #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghubetina merged 1 commit into from
Sep 24, 2026
Merged

Use Selenium’s default session request timeout #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .devcontainer/compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ services:
environment:
SE_NODE_MAX_SESSIONS: "2"
SE_NODE_OVERRIDE_MAX_SESSIONS: "true"
SE_SESSION_REQUEST_TIMEOUT: "30"
shm_size: 2gb

postgres:
Expand Down
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,11 @@ their generated `.devcontainer/compose.yaml` and the running container's Compose
[browser-testing instructions](README.md#7-open-your-app). The generated health check uses Selenium's supplied
`/opt/bin/check-grid.sh`; Compose owns readiness for that command and fresh generated Dev Container startup.

Selenium uses its upstream session-request queue deadline, currently 300 seconds. The generated app's Ruby client
retains its separate 60-second HTTP read timeout, so an unanswered session request can still fail sooner.
The former 30-second override rejected a slow first browser start in Codespaces; the observation and remaining
qualification are tracked in [Service #729](https://github.com/firstdraft/firstdraft/issues/729).

The Docker-outside-of-Docker Feature reaches the host daemon: that host is a disposable VM in Codespaces, but it is
the developer's own machine on the supported local path. Do not run an untrusted workspace or agent with that socket
mounted. The planning workspace starts Selenium only when browser proof requests it.
Expand Down
Loading