Allow attachment without the planning archive - #38
Merged
Merged
Conversation
raghubetina
force-pushed
the
codex/729-generated-selenium-guide
branch
from
September 19, 2026 00:46
1ff1993 to
6cb6cce
Compare
This was referenced Sep 19, 2026
The planning archive is optional after root adoption. Guard both helper paths while preserving root precedence and real refresh errors. Keep existing container metadata and provider qualification separate.
raghubetina
changed the base branch from
codex/729-generated-selenium-guide
to
main
September 23, 2026 18:10
raghubetina
force-pushed
the
codex/730-archive-workflow
branch
from
September 23, 2026 18:10
5cd2f49 to
1c1493d
Compare
raghubetina
marked this pull request as ready for review
September 23, 2026 19:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the optional planning archive after root Compile currently leaves the inherited attach command trying to execute a missing file. Guard both helper locations: prefer the executable root helper, use the executable archived helper otherwise, and succeed without refreshing ports when neither exists. Existing helper failures still propagate.
Reconciles the old draft onto current main
45df3ab1c61d01b444440058cf2f817e3c2e9b9e. It retains the released CLI/plugin 0.6.0 pins and merged preview/Compose guidance. Existing Codespaces retain their creation-time lifecycle commands.Validation at head
1c1493d1035770ec25f69fd688fbf6164f926b33:script/checkandgit diff --checkpass. The old configured command reproduces the missing-helper failure; the new fixtures exercise both helper locations, precedence, absence/non-executability, listener states, and real helper-error propagation.CI=1 bin/cipassed 126 examples with the archive present. A later focused archive-absent Books run had 4 examples / 1 failure: Selenium session creation timed out after the first restart. No retry or source repair was performed. Archive-absent full-system qualification remains unproven; Service #729 owns the immediate qualification remainder. This session-creation failure is distinct from #728 axe timeouts.The bounded provider receipts are handed to the coordinator for Service #730. This does not establish that every older Codespace or future private-port relay incident works without its existing refresh helper.