Repository navigation
votor: replace votor messages with receive and serde fixtures - #139
Open
nishk-jump wants to merge 1 commit into
Open
nishk-jump wants to merge 1 commit into
nishk-jump wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removed protobuf field names and numbers should be reserved to prevent future wire-format collisions.
1 open finding
What changed in this PR
Replaces the legacy Votor consensus fixtures with vote serialization and deserialization fixtures.
Changes:
- Defines vote serde inputs, outputs, and wire variants.
- Adds Nanopb size constraints.
- Regenerates Rust protobuf bindings.
| File | Description |
|---|---|
proto/votor.proto |
Defines the new Votor vote serde fixtures. |
proto/votor.options |
Configures fixed and maximum field sizes. |
src/generated/org.solana.sealevel.v1.rs |
Updates generated Rust bindings. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| bytes block_hash = 2; | ||
| uint64 signer = 3; | ||
| /* Exactly 32 bytes */ | ||
| bytes block_id = 2; |
Author
There was a problem hiding this comment.
I think the clankers just yapping, no harness ever used them, and no fixtures exist for them.
nishk-jump
force-pushed
the
votor-vote-serde
branch
from
October 13, 2026 02:18
b01aa10 to
4a8e8c9
Compare
nishk-jump
changed the title
nishk-jump
changed the title
nishk-jump
force-pushed
the
votor-vote-serde
branch
3 times, most recently
from
October 13, 2026 19:23
71e0543 to
598faf7
Compare
nishk-jump
changed the title
nishk-jump
force-pushed
the
votor-vote-serde
branch
3 times, most recently
from
October 13, 2026 22:23
305f87f to
cec1938
Compare
nishk-jump
changed the title
nishk-jump
force-pushed
the
votor-vote-serde
branch
from
October 13, 2026 22:34
cec1938 to
281cf7a
Compare
nishk-jump
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the votor messages with receive, vote serialize and cert serialize fixtures.