Repository navigation
repair: add solfuzz schema - #136
Open
peterschrammel wants to merge 2 commits into
Open
peterschrammel wants to merge 2 commits into
peterschrammel wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Removing Cargo link metadata breaks downstream schema-directory discovery.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds two repair-harness schema generations and releases them as version 18.0.0.
Changes:
- Adds topology-based V1 and event-trace V2 repair schemas.
- Adds nanopb allocation options and generated Rust bindings.
- Updates the crate version to 18.0.0.
| File | Description |
|---|---|
src/generated/org.solana.sealevel.v1.rs |
Adds generated Rust repair types. |
proto/repair.proto |
Defines both repair schema versions. |
proto/repair.options |
Configures nanopb pointer-backed fields. |
Cargo.toml |
Updates package metadata and version. |
Cargo.lock |
Records version 18.0.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
peterschrammel
force-pushed
the
ps/repair-harness
branch
2 times, most recently
from
September 24, 2026 13:46
f4e1618 to
3c02773
Compare
Add RepairContextV1, RepairEffectsV1, and RepairFixtureV1 (plus the nested RepairSlotDescV1, RepairGapV1, RepairPeerV1, and RepairShredIdV1 messages) for the sol_compat_repair_v1 differential target. The schema describes a repair-stack scenario declaratively: a slot topology, a set of shred/FEC-set/slot gaps to repair, and run configuration (peers, publish slot, insertion order, turbine/elapsed- time overrides). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
peterschrammel
force-pushed
the
ps/repair-harness
branch
from
September 24, 2026 14:16
3c02773 to
b390a1d
Compare
peterschrammel
force-pushed
the
ps/repair-harness
branch
from
September 28, 2026 09:36
b390a1d to
7b384b4
Compare
Add RepairContextV2, RepairEffectsV2, and RepairFixtureV2 (plus the nested RepairChainSlot, RepairShredSource, RepairShredKind, DeliverShred, ServeRequests, Confirm, SetRoot, PeerFault, AdvanceTime, RepairEvent, RepairSlotState, RepairSnapshot, RepairRequestKind, and RepairRequest messages) for the sol_compat_repair_v2 differential target. The schema describes a repair-stack scenario as a ground-truth chain plus an ordered event trace (deliver/serve/confirm/set_root/fault/time) that the target's driver applies in order, reporting the sequence of resulting states. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
peterschrammel
force-pushed
the
ps/repair-harness
branch
from
September 28, 2026 10:03
7b384b4 to
36ab16f
Compare
mjain-jump
requested changes
Oct 1, 2026
mjain-jump
left a comment
mjain-jump
left a comment
Collaborator
There was a problem hiding this comment.
this needs a closer look by someone who is more familiar with the repair code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the solfuzz repair harness (comes in two versions fuzzing different aspects):