Repository navigation
remove GDB helpers - #12521
Open
ripatel-fd wants to merge 1 commit into
Open
remove GDB helpers#12521ripatel-fd wants to merge 1 commit into
ripatel-fd wants to merge 1 commit into
Conversation
ripatel-fd
force-pushed
the
ripatel/gdb-helpers
branch
from
October 23, 2026 23:31
baf12c0 to
62e9b47
Compare
|
┌─ ⚡ PERF · e2b96c3 vs main@3a633f8 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet … … …
│ bench tps, localnet 665,750 tps 669,029 tps · +0.49%
+│ snapshot load, testnet 5.22 s 4.92 s ▼ -5.60%
│ mem total, mainnet 150.35 GiB 150.35 GiB · 0.00%
│ mem total, testnet 86.66 GiB 86.66 GiB · 0.00%
│ clean compile, firedancer 3.18 s 3.17 s · -0.24%
│ binary size, firedancer 57.92 MB 57.92 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ RUNNING · replay pending · snapshot done · bench done @@
└─────────────────────────────────────────────────────────────────────history · 3 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
+│ e2b96c3 … +0.49% -5.60% 0.00% 0.00% -0.24% 0.00%
│ 102df85 -0.06% -0.30% +0.06% 0.00% 0.00% -0.06% 0.00%
│ 62e9b47 … … … … … … …
└──────────────────────────────────────────────────────────────────────────────── |
ripatel-fd
force-pushed
the
ripatel/gdb-helpers
branch
from
October 23, 2026 23:32
62e9b47 to
102df85
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The script-test runner still invokes the deleted Base58 test, causing clean-build CI script tests to fail.
No open issues 🎉
What changed in this PR
Removes Firedancer’s bundled debugger helpers and related development tooling.
Changes:
- Removes embedded GDB Base58 printers, their tests, and build registration.
- Deletes debugger wrappers and VS Code build/launch configurations.
- Removes the ledger backtest’s
--debugoption.
| File | Description |
|---|---|
| src/flamenco/runtime/tests/run_ledger_backtest.sh | Removes --debug handling. |
| src/app/shared/gdb/test_gdb_base58.sh | Deletes the printer test script. |
| src/app/shared/gdb/test_gdb_base58.c | Deletes printer test fixtures. |
| src/app/shared/gdb/Local.mk | Removes helper and test build rules. |
| src/app/shared/gdb/fd_gdb_scripts.S | Removes embedded GDB scripts. |
| src/app/shared/gdb/fd_gdb_scripts.h | Deletes the helper linkage header. |
| src/app/shared/gdb/fd_base58_gdb.py | Deletes Base58 printers and commands. |
| src/app/firedancer-dev/main.c | Removes the GDB helper include. |
| src/app/fddbg/main.c | Deletes the capability-enabled debugger wrapper. |
| src/app/fddbg/Local.mk | Removes the wrapper’s build target. |
| contrib/tool/fd_gdb | Deletes the GDB launcher script. |
| contrib/debug.gdb | Deletes backtest debugger commands. |
| .vscode/tasks.json | Removes the editor build task. |
| .vscode/launch.json | Removes the editor launch configuration. |
Review effort: Balanced
mmcgee-jump
previously approved these changes
Oct 23, 2026
ripatel-fd
enabled auto-merge (rebase)
October 23, 2026 23:34
no one should be debugging by hand anymore. much faster to use LLM-assisted debug workflows.
ripatel-fd
force-pushed
the
ripatel/gdb-helpers
branch
from
October 23, 2026 23:41
102df85 to
e2b96c3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no one should be debugging by hand anymore. much faster to use
LLM-assisted debug workflows.