Repository navigation
replay: remove unused next_leader_tickcount - #12519
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The cleanup preserves timestamp behavior and leaves no dangling references to the removed fields.
No open issues 🎉
What changed in this PR
Removes unused leader tick-count state from the replay tile and simplifies leader timestamp recording.
Changes:
- Removes
next_leader_tickcount,tick_per_ns, and their initialization and recalculation code. - Reuses
now_nanosfor the leader-slot start timestamp, preserving the existing calculation. - Updates test setup to match the smaller replay context.
| File | Description |
|---|---|
src/discof/replay/test_replay_tile.c |
Removes initialization of deleted fields. |
src/discof/replay/fd_replay_tile.c |
Removes unused timing calculations and simplifies timestamp assignment. |
src/discof/replay/fd_replay_tile_private.h |
Removes the unused replay context fields. |
Review effort: Balanced
┌─ ⚡ PERF · 27a4a4c vs main@b8394ed ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 13,070 tps 13,156 tps · +0.66%
│ bench tps, localnet 668,320 tps 667,947 tps · -0.06%
│ snapshot load, testnet 4.94 s 4.94 s · +0.11%
+│ mem total, mainnet 150.35 GiB 150.35 GiB ▼ 0.00%
+│ mem total, testnet 86.66 GiB 86.66 GiB ▼ 0.00%
│ clean compile, firedancer 3.15 s 3.12 s · -0.92%
│ binary size, firedancer 57.92 MB 57.92 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 2 IMPROVED · 5 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 2 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
+│ 27a4a4c +0.66% -0.06% +0.11% 0.00% 0.00% -0.92% 0.00%
│ 56ff3b9 -0.70% -0.53% +0.21% 0.00% 0.00% -0.01% 0.00%
└──────────────────────────────────────────────────────────────────────────────── |
ripatel-fd
force-pushed
the
ripatel/remove-leader-tickcount
branch
from
October 23, 2026 21:27
56ff3b9 to
27a4a4c
Compare
topointon-jump
approved these changes
Oct 23, 2026
ripatel-fd
enabled auto-merge (rebase)
October 23, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove unused Tower BFT leader slot timing logic