Repository navigation
replay: rename gross ag prefixes - #12517
Merged
Merged
Conversation
┌─ ⚡ PERF · 623e74d vs main@d44b459 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 13,637 tps 13,693 tps · +0.41%
│ bench tps, localnet 892,097 tps 892,084 tps · 0.00%
│ snapshot load, testnet 4.87 s 4.86 s · -0.06%
│ mem total, mainnet 150.35 GiB 150.35 GiB · 0.00%
│ mem total, testnet 86.66 GiB 86.66 GiB · 0.00%
│ clean compile, firedancer 3.19 s 3.18 s · -0.12%
│ binary size, firedancer 57.94 MB 57.94 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 0 IMPROVED · 7 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 2 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
│ 623e74d +0.41% 0.00% -0.06% 0.00% 0.00% -0.12% 0.00%
│ 5efac7f +0.42% -0.65% -0.08% 0.00% 0.00% -0.01% 0.00%
└──────────────────────────────────────────────────────────────────────────────── |
ripatel-fd
previously approved these changes
Oct 23, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review supports consistent renaming and preserved lookup and flag behavior, with no blocking issues identified; builds and tests were not run.
No open issues 🎉
What changed in this PR
This PR removes legacy ag naming from Firedancer’s replay internals and updates the corresponding tests.
Changes:
- Renames block-ID map symbols and replay/scheduler helpers.
- Replaces the block-ID lookup wrapper with equivalent direct map queries.
- Converts five scheduler state flags to one-bit unsigned fields.
| File | Description |
|---|---|
src/discof/replay/test_replay_tile.c |
Updates test calls, setup, and comments for renamed symbols. |
src/discof/replay/fd_sched.c |
Renames marker handlers and packs state flags into bitfields. |
src/discof/replay/fd_replay_tile.c |
Updates replay helpers and map references; inlines map lookups. |
src/discof/replay/fd_replay_tile_private.h |
Renames map declarations and removes obsolete Alpenglow-only comments. |
Review effort: Balanced
emwang-jump
force-pushed
the
emwang/replay-ag-rename
branch
from
October 23, 2026 21:02
5efac7f to
623e74d
Compare
emwang-jump
enabled auto-merge (rebase)
October 23, 2026 21:03
ripatel-fd
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.