Skip to content

config: development flag for repair telemetry - #12516

Open
lidatong wants to merge 1 commit into
mainfrom
chali/repair/request-telemetry-flag
Open

lidatong wants to merge 1 commit into
mainfrom
chali/repair/request-telemetry-flag

Conversation

@lidatong

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 20:47
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
 ┌─ ⚡ PERF · 53ab319 vs main@d44b459 ─────────────────────────────────
 │ SUITE                               BASELINE          NEW         Δ
 │ replay tps, mainnet               12,896 tps   12,874 tps  ·  -0.17%
 │ bench tps, localnet              668,307 tps  666,217 tps  ·  -0.31%
 │ snapshot load, testnet                4.89 s       4.89 s  ·  -0.08%
+│ mem total, mainnet                150.35 GiB   150.35 GiB  ▼   0.00%
+│ mem total, testnet                 86.66 GiB    86.66 GiB  ▼   0.00%
 │ clean compile, firedancer             3.18 s       3.23 s  ·  +1.48%
 │ binary size, firedancer             57.94 MB     57.94 MB  ·  +0.01%
 ├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 2 IMPROVED · 5 NOISE @@
 └─────────────────────────────────────────────────────────────────────

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review shows consistent end-to-end configuration wiring and telemetry-only gating with no blocking defects; builds and tests were not run.

No open issues 🎉

What changed in this PR

Adds an opt-in development flag for repair-request telemetry, keeping high-volume reporting disabled by default.

Changes:

  • Adds development.event.report_repair_requests to configuration parsing, JSON output, and documented defaults.
  • Passes the flag through topology configuration into the repair tile.
  • Gates repair-request events and associated telemetry lookups on the flag.
File Description
src/​disco/​topo/​fd_topo.h Adds the repair telemetry flag to tile configuration.
src/​disco/​repair/​fd_repair_tile.c Initializes the flag and gates telemetry work.
src/​app/​shared/​fd_config.h Adds the development configuration field.
src/​app/​shared/​fd_config_parse.c Parses the new boolean option.
src/​app/​shared/​fd_config_json.c Includes the option in JSON output.
src/​app/​firedancer/​topology.c Passes the option into repair tile configuration.
src/​app/​firedancer/​config/​default.toml Documents the option and defaults it to false.

Review effort: Balanced

@lidatong
lidatong enabled auto-merge (squash) October 23, 2026 20:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants