Repository navigation
Conversation
┌─ ⚡ PERF · 53ab319 vs main@d44b459 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 12,896 tps 12,874 tps · -0.17%
│ bench tps, localnet 668,307 tps 666,217 tps · -0.31%
│ snapshot load, testnet 4.89 s 4.89 s · -0.08%
+│ mem total, mainnet 150.35 GiB 150.35 GiB ▼ 0.00%
+│ mem total, testnet 86.66 GiB 86.66 GiB ▼ 0.00%
│ clean compile, firedancer 3.18 s 3.23 s · +1.48%
│ binary size, firedancer 57.94 MB 57.94 MB · +0.01%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 2 IMPROVED · 5 NOISE @@
└───────────────────────────────────────────────────────────────────── |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Static review shows consistent end-to-end configuration wiring and telemetry-only gating with no blocking defects; builds and tests were not run.
No open issues 🎉
What changed in this PR
Adds an opt-in development flag for repair-request telemetry, keeping high-volume reporting disabled by default.
Changes:
- Adds
development.event.report_repair_requeststo configuration parsing, JSON output, and documented defaults. - Passes the flag through topology configuration into the repair tile.
- Gates repair-request events and associated telemetry lookups on the flag.
| File | Description |
|---|---|
src/disco/topo/fd_topo.h |
Adds the repair telemetry flag to tile configuration. |
src/disco/repair/fd_repair_tile.c |
Initializes the flag and gates telemetry work. |
src/app/shared/fd_config.h |
Adds the development configuration field. |
src/app/shared/fd_config_parse.c |
Parses the new boolean option. |
src/app/shared/fd_config_json.c |
Includes the option in JSON output. |
src/app/firedancer/topology.c |
Passes the option into repair tile configuration. |
src/app/firedancer/config/default.toml |
Documents the option and defaults it to false. |
Review effort: Balanced
lidatong
enabled auto-merge (squash)
October 23, 2026 20:51
emwang-jump
approved these changes
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.