Repository navigation
Remove Alpenglow conditionals - #12515
Merged
Merged
Conversation
ripatel-fd
commented
Oct 23, 2026
ripatel-fd
commented
Contributor
- restore: remove Alpenglow conditionals
- rpc: remove Alpenglow conditionals
- store: remove Alpenglow conditionals
- shred: remove Alpenglow conditionals
┌─ ⚡ PERF · 05f0d4e vs main@c85b7de ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 13,623 tps 13,614 tps · -0.07%
│ bench tps, localnet 666,903 tps 668,237 tps · +0.20%
│ snapshot load, testnet 4.88 s 4.86 s · -0.35%
!│ mem total, mainnet 150.35 GiB 150.35 GiB ▲ 0.00%
!│ mem total, testnet 86.66 GiB 86.66 GiB ▲ 0.00%
│ clean compile, firedancer 3.23 s 3.21 s · -0.63%
│ binary size, firedancer 57.92 MB 57.91 MB · -0.02%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 2 WARNINGS · 0 IMPROVED · 5 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 4 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
!│ 05f0d4e -0.07% +0.20% -0.35% 0.00% 0.00% -0.63% -0.02%
│ 9115db1 +0.04% +0.03% -0.16% 0.00% 0.00% +0.51% -0.01%
│ efc77d2 +0.66% -0.51% +0.50% 0.00% 0.00% -0.19% -0.01%
│ d7383a9 … -0.14% -0.02% 0.00% 0.00% -0.21% -0.01%
└──────────────────────────────────────────────────────────────────────────────── |
ripatel-fd
force-pushed
the
ripatel/ag-cond
branch
from
October 23, 2026 20:40
d7383a9 to
efc77d2
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A dangling test call blocks the unit-test build, concurrent store workers share an unsafe partition, and a restore fixture no longer reaches its intended validation.
3 open issues
What changed in this PR
This PR makes Alpenglow behavior unconditional across snapshot restore, RPC, store, and shred processing, removing obsolete mode flags and updating related callers and tests.
Changes:
- Remove Alpenglow flags from tile configuration and runtime state.
- Make snapshot block-ID validation, RPC root handling, and store indexing unconditional.
- Update store API calls and remove legacy-mode tests.
| File | Description |
|---|---|
src/flamenco/runtime/test_slot_params.c |
Remove the hashes-per-tick test definition. |
src/discof/rpc/test_rpc_tile.c |
Remove mode switching from RPC tests. |
src/discof/rpc/fd_rpc_tile.c |
Apply Alpenglow root handling unconditionally. |
src/discof/restore/fd_snapin_tile.c |
Require snapshot block IDs unconditionally. |
src/discof/replay/test_replay_tile.c |
Update store constructor calls. |
src/disco/topo/fd_topo.h |
Remove obsolete tile mode fields. |
src/disco/store/test_store.c |
Update store fixtures and remove no-root-map tests. |
src/disco/store/fd_store.h |
Simplify store interfaces and document required partitions. |
src/disco/store/fd_store.c |
Always maintain slot partitions and disk root indexes. |
src/disco/shred/fd_shred_tile.c |
Remove mode gates from shred processing. |
src/disco/repair/test_rserve_tile.c |
Update repair-server store setup. |
src/app/shared/fd_action.h |
Remove the obsolete require_tower argument field. |
src/app/firedancer/topology.c |
Remove Alpenglow flag assignments. |
src/app/firedancer/callbacks.c |
Update store allocation callbacks. |
Review effort: Balanced
topointon-jump
previously approved these changes
Oct 23, 2026
ripatel-fd
force-pushed
the
ripatel/ag-cond
branch
from
October 23, 2026 21:02
efc77d2 to
9115db1
Compare
also some drive-by fixes: - remove slot time vs hash-per-tick tests - remove unused topo.replay.alpenglow flag
ripatel-fd
force-pushed
the
ripatel/ag-cond
branch
from
October 23, 2026 21:35
9115db1 to
05f0d4e
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes preserve behavior already selected by production topology, with callers and fixtures updated consistently and no blocking issues identified in static review.
No open issues 🎉
1 resolved since last review
Review effort: Balanced
ripatel-fd
enabled auto-merge (rebase)
October 23, 2026 21:39
topointon-jump
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.