Repository navigation
replay: track and publish scheduler slot states - #12513
Merged
jherrera-jump merged 1 commit intoOct 23, 2026
Merged
Conversation
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 20:14
c933175 to
6ff50eb
Compare
┌─ ⚡ PERF · 1ab7315 vs main@c85b7de ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 12,817 tps 12,889 tps · +0.56%
│ bench tps, localnet 666,155 tps 671,422 tps · +0.79%
│ snapshot load, testnet 4.88 s 4.87 s · -0.31%
!│ mem total, mainnet 150.35 GiB 150.35 GiB ▲ 0.00%
!│ mem total, testnet 86.66 GiB 86.66 GiB ▲ 0.00%
│ clean compile, firedancer 3.17 s 3.19 s · +0.77%
│ binary size, firedancer 57.92 MB 57.93 MB · +0.02%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 2 WARNINGS · 0 IMPROVED · 5 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 5 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
!│ 1ab7315 +0.56% +0.79% -0.31% 0.00% 0.00% +0.77% +0.02%
!│ 98ed197 +0.02% -0.30% +0.27% 0.00% 0.00% -0.58% +0.02%
!│ 3638370 +0.13% -0.19% +0.26% 0.00% 0.00% +0.20% +0.02%
!│ 445685e +0.22% 0.00% -4.34% 0.00% 0.00% -0.05% +0.02%
+│ 6ff50eb -0.15% -0.18% +1.00% 0.00% 0.00% +0.73% +0.02%
└──────────────────────────────────────────────────────────────────────────────── |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
An unresolved lifecycle-timing issue and timing-sensitive publication changes require correction, runtime validation, and final human review.
1 open issue
What changed in this PR
Adds scheduler slot-state tracking and publishes replay timing intervals for downstream consumers.
Changes:
- Tracks debounced blocking and finish states across block lifecycle transitions.
- Publishes batched state intervals on
replay_outand increases the publication burst allowance. - Updates scheduler footprint expectations, interval tests, and replay mocks.
| File | Description |
|---|---|
src/discof/replay/test_sched.c |
Updates footprint checks and tests non-overlapping network-wait intervals. |
src/discof/replay/test_replay_tile.c |
Adds a mock for draining scheduler states. |
src/discof/replay/fd_sched.h |
Defines slot states, interval records, and the drain API. |
src/discof/replay/fd_sched.c |
Implements state tracking, debouncing, buffering, and lifecycle hooks. |
src/discof/replay/fd_replay_tile.h |
Defines the slot-state replay message. |
src/discof/replay/fd_replay_tile.c |
Publishes state batches and adjusts routing and burst capacity. |
Review effort: Balanced
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 20:43
6ff50eb to
445685e
Compare
jherrera-jump
marked this pull request as ready for review
October 23, 2026 20:52
yufeng-jump
previously approved these changes
Oct 23, 2026
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 21:20
445685e to
3638370
Compare
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 21:35
3638370 to
b9b5609
Compare
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 21:38
b9b5609 to
98ed197
Compare
jherrera-jump
force-pushed
the
jherrera/replay-slot-states
branch
from
October 23, 2026 21:41
98ed197 to
1ab7315
Compare
yufeng-jump
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.