Skip to content

flamenco, runtime: enforce validator location registration - #12323

Open
topointon-jump wants to merge 1 commit into
firedancer-geo-aware-leader-schedule-simd-0674from
firedancer-geo-aware-leader-schedule-mandatory-validator-location
Open

topointon-jump wants to merge 1 commit into
firedancer-geo-aware-leader-schedule-simd-0674from
firedancer-geo-aware-leader-schedule-mandatory-validator-location

Conversation

@topointon-jump

@topointon-jump topointon-jump commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

When this feature gate (enforce_validator_location_registration) is active, vote accounts without a valid location set are excluded from the VAT set.

@topointon-jump
topointon-jump added this pull request to stack #12320 October 16, 2026 04:22
@topointon-jump topointon-jump changed the title flamenco, runtime: enforce validator location registration [WIP] flamenco, runtime: enforce validator location registration Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
 ┌─ ⚡ PERF · b588abe vs main@1a9efce ─────────────────────────────────
 │ SUITE                               BASELINE          NEW         Δ
 │ replay tps, mainnet               28,534 tps   28,448 tps  ·  -0.30%
 │ bench tps, localnet              664,748 tps  664,884 tps  ·  +0.02%
 │ snapshot load, testnet                3.78 s       3.80 s  ·  +0.50%
 │ mem total, mainnet                150.13 GiB   150.13 GiB  ·   0.00%
 │ mem total, testnet                 87.25 GiB    87.25 GiB  ·   0.00%
 │ mem total, ag mainnet             150.94 GiB   150.94 GiB  ·   0.00%
 │ clean compile, firedancer             3.48 s       3.50 s  ·  +0.55%
 │ binary size, firedancer             60.13 MB     60.14 MB  ·   0.00%
 ├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 0 IMPROVED · 8 NOISE @@
 └─────────────────────────────────────────────────────────────────────
history · 11 pushes
 ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
 │ HEAD         TPS    BENCH     SNAP    MEM·M    MEM·T     AG·M  COMPILE   BINARY
 │ b588abe   -0.30%   +0.02%   +0.50%    0.00%    0.00%    0.00%   +0.55%    0.00%
 │ 1b444d8   -0.53%   -0.10%   -0.17%    0.00%    0.00%    0.00%   +0.18%    0.00%
 │ 51f4738   -0.06%   +0.41%   +0.69%    0.00%    0.00%    0.00%   +0.18%    0.00%
 │ 0ccea77   -0.13%   -0.13%   +0.02%    0.00%    0.00%    0.00%   +0.05%    0.00%
 │ b62421e   +0.48%   -0.37%   +0.15%    0.00%    0.00%    0.00%   +0.02%    0.00%
 │ 86a4541   +0.81%   -0.34%   +0.52%    0.00%    0.00%    0.00%   +1.03%    0.00%
 │ c5068d0        …        …   -0.13%        …        …        …        …        …
 │ e22e9b9   +0.19%   +0.26%   +0.41%    0.00%    0.00%    0.00%   -0.10%    0.00%
-│ 083412b   -0.63%   -0.16%   +5.92%    0.00%    0.00%    0.00%        …    0.00%
!│ 3cf294d   -1.18%   -0.73%   -0.72%    0.00%    0.00%    0.00%   +0.97%    0.00%
!│ 4bdc6a1   +0.26%   -0.42%   +4.39%    0.00%    0.00%    0.00%   +0.41%    0.00%
 └────────────────────────────────────────────────────────────────────────────────

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:42
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 4bdc6a1 to ba1fcb5 Compare October 16, 2026 17:42
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from ba1fcb5 to 3cf294d Compare October 16, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Consensus-critical admission changes remain explicitly WIP with a pending SIMD and require runtime validation and final human review.

0 open findings

What changed in this PR

Adds feature-gated V5 vote-account admission as part of the geo-aware leader schedule.

Changes:

  • Requires valid V5 vote accounts when location-registration enforcement is active.
  • Adds tests for genesis activation, epoch-boundary activation, and unchecked location coordinates.
  • Registers the feature and updates generated definitions.
File Description
src/​flamenco/​stakes/​fd_stakes.c Enforces feature-gated V5 admission.
src/​flamenco/​runtime/​test_vat_refresh_vote_accounts.c Tests enforcement and activation behavior.
src/​flamenco/​features/​feature_map.json Registers the enforcement feature.
src/​flamenco/​features/​fd_features_generated.h Updates generated feature fields and identifiers.
src/​flamenco/​features/​fd_features_generated.c Updates generated feature lookup entries.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI balanced review requested due to automatic review settings October 16, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The WIP consensus-critical change needs human confirmation against the pending SIMD before approval.

0 open findings

🧠 Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 16, 2026 21:10
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 3cf294d to 083412b Compare October 16, 2026 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

These consensus-affecting WIP changes need human review and runtime-test validation before approval.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 19, 2026 15:50
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 083412b to e22e9b9 Compare October 19, 2026 15:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The explicitly unfinished change affects consensus-critical validator eligibility and needs runtime test validation and final human review.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 19, 2026 19:14
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from e22e9b9 to c5068d0 Compare October 19, 2026 19:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The WIP changes affect consensus-critical stake admission and need runtime validation and human review against finalized SIMD requirements.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 19, 2026 19:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The explicitly WIP change affects consensus-critical validator eligibility and needs runtime validation and final human review.

No open issues 🎉

Review effort: Balanced

@topointon-jump topointon-jump changed the title [WIP] flamenco, runtime: enforce validator location registration flamenco, runtime: enforce validator location registration Oct 19, 2026
Copilot AI balanced review requested due to automatic review settings October 19, 2026 22:33
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from b62421e to 0ccea77 Compare October 19, 2026 22:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

VAT admission affects consensus and warrants human review, with the new runtime tests not executed during this review.

No open issues 🎉

Review effort: Balanced

@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 0ccea77 to fe3981c Compare October 19, 2026 22:43
Copilot AI balanced review requested due to automatic review settings October 19, 2026 22:43
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from fe3981c to 51f4738 Compare October 19, 2026 22:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

No concrete defects were identified, but this consensus-critical eligibility change needs runtime test validation and human approval.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 19, 2026 22:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Consensus-critical stake filtering warrants human review and execution of the new runtime regression tests.

No open issues 🎉

Review effort: Balanced

@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 51f4738 to 1b444d8 Compare October 21, 2026 20:13
Copilot AI balanced review requested due to automatic review settings October 21, 2026 20:13
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 51f4738 to 1b444d8 Compare October 21, 2026 20:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The consensus-sensitive admission change needs human validation and runtime test execution.

No open issues 🎉

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings October 22, 2026 01:23
@topointon-jump
topointon-jump force-pushed the firedancer-geo-aware-leader-schedule-mandatory-validator-location branch from 1b444d8 to b588abe Compare October 22, 2026 01:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

This consensus-critical eligibility change needs runtime test results and final human review before approval.

No open issues 🎉

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants