Repository navigation
flamenco, runtime: enforce validator location registration - #12323
Open
topointon-jump wants to merge 1 commit into
Conversation
topointon-jump
added this pull request to stack #12320
October 16, 2026 04:22
┌─ ⚡ PERF · b588abe vs main@1a9efce ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 28,534 tps 28,448 tps · -0.30%
│ bench tps, localnet 664,748 tps 664,884 tps · +0.02%
│ snapshot load, testnet 3.78 s 3.80 s · +0.50%
│ mem total, mainnet 150.13 GiB 150.13 GiB · 0.00%
│ mem total, testnet 87.25 GiB 87.25 GiB · 0.00%
│ mem total, ag mainnet 150.94 GiB 150.94 GiB · 0.00%
│ clean compile, firedancer 3.48 s 3.50 s · +0.55%
│ binary size, firedancer 60.13 MB 60.14 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 0 IMPROVED · 8 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 11 pushes ┌─ HISTORY · Δ vs main, per push, newest first ──────────────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T AG·M COMPILE BINARY
│ b588abe -0.30% +0.02% +0.50% 0.00% 0.00% 0.00% +0.55% 0.00%
│ 1b444d8 -0.53% -0.10% -0.17% 0.00% 0.00% 0.00% +0.18% 0.00%
│ 51f4738 -0.06% +0.41% +0.69% 0.00% 0.00% 0.00% +0.18% 0.00%
│ 0ccea77 -0.13% -0.13% +0.02% 0.00% 0.00% 0.00% +0.05% 0.00%
│ b62421e +0.48% -0.37% +0.15% 0.00% 0.00% 0.00% +0.02% 0.00%
│ 86a4541 +0.81% -0.34% +0.52% 0.00% 0.00% 0.00% +1.03% 0.00%
│ c5068d0 … … -0.13% … … … … …
│ e22e9b9 +0.19% +0.26% +0.41% 0.00% 0.00% 0.00% -0.10% 0.00%
-│ 083412b -0.63% -0.16% +5.92% 0.00% 0.00% 0.00% … 0.00%
!│ 3cf294d -1.18% -0.73% -0.72% 0.00% 0.00% 0.00% +0.97% 0.00%
!│ 4bdc6a1 +0.26% -0.42% +4.39% 0.00% 0.00% 0.00% +0.41% 0.00%
└──────────────────────────────────────────────────────────────────────────────── |
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 16, 2026 17:42
4bdc6a1 to
ba1fcb5
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 16, 2026 17:44
ba1fcb5 to
3cf294d
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Consensus-critical admission changes remain explicitly WIP with a pending SIMD and require runtime validation and final human review.
0 open findings
What changed in this PR
Adds feature-gated V5 vote-account admission as part of the geo-aware leader schedule.
Changes:
- Requires valid V5 vote accounts when location-registration enforcement is active.
- Adds tests for genesis activation, epoch-boundary activation, and unchecked location coordinates.
- Registers the feature and updates generated definitions.
| File | Description |
|---|---|
| src/flamenco/stakes/fd_stakes.c | Enforces feature-gated V5 admission. |
| src/flamenco/runtime/test_vat_refresh_vote_accounts.c | Tests enforcement and activation behavior. |
| src/flamenco/features/feature_map.json | Registers the enforcement feature. |
| src/flamenco/features/fd_features_generated.h | Updates generated feature fields and identifiers. |
| src/flamenco/features/fd_features_generated.c | Updates generated feature lookup entries. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 16, 2026 21:10
3cf294d to
083412b
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 19, 2026 15:50
083412b to
e22e9b9
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 19, 2026 19:14
e22e9b9 to
c5068d0
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 19, 2026 22:33
b62421e to
0ccea77
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 19, 2026 22:43
0ccea77 to
fe3981c
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 19, 2026 22:46
fe3981c to
51f4738
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 21, 2026 20:13
51f4738 to
1b444d8
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 21, 2026 20:13
51f4738 to
1b444d8
Compare
topointon-jump
force-pushed
the
firedancer-geo-aware-leader-schedule-mandatory-validator-location
branch
from
October 22, 2026 01:23
1b444d8 to
b588abe
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this feature gate (
enforce_validator_location_registration) is active, vote accounts without a valid location set are excluded from the VAT set.