Repository navigation
ci: check build with old kernel headers - #10938
Draft
ripatel-fd wants to merge 1 commit into
Draft
ripatel-fd wants to merge 1 commit into
ripatel-fd wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI coverage for compilation against Linux 4.19 headers and AF_XDP compatibility shims.
Changes:
- Adds fallback AF_XDP constants and structures.
- Uses compatibility types in XSK setup.
- Adds an old-kernel-header workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/old_kernel_headers.yml |
Adds compatibility build check. |
src/waltz/xdp/fd_xsk.h |
Defines portable AF_XDP types and constants. |
src/waltz/xdp/fd_xsk.c |
Uses the compatibility offset types. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Performance Measurements ⏳
|
ripatel-fd
force-pushed
the
ripatel/kernel-ci
branch
from
September 8, 2026 05:41
363505c to
ba8eb4d
Compare
┌─ ⚡ PERF · 9608fd5 vs main@d744a76 ─────────────────────────────────
│ SUITE BASELINE NEW Δ
│ replay tps, mainnet 28,376 tps 28,414 tps · +0.13%
│ bench tps, localnet 128,647 tps 128,646 tps · 0.00%
│ snapshot load, testnet 15.37 s 15.30 s · -0.47%
│ mem total, mainnet 171.43 GiB 171.43 GiB · 0.00%
│ mem total, testnet 102.30 GiB 102.30 GiB · 0.00%
│ clean compile, firedancer 228.1 cpu·s 232.5 cpu·s · +1.93%
│ binary size, firedancer 85.81 MB 85.81 MB · 0.00%
├─────────────────────────────────────────────────────────────────────
@@ 0 REGRESSIONS · 0 WARNINGS · 0 IMPROVED · 7 NOISE @@
└─────────────────────────────────────────────────────────────────────history · 2 pushes ┌─ HISTORY · Δ vs main, per push, newest first ─────────────────────────
│ HEAD TPS BENCH SNAP MEM·M MEM·T COMPILE BINARY
│ 9608fd5 +0.13% 0.00% -0.47% 0.00% 0.00% +1.93% 0.00%
│ ba8eb4d … … … … … … …
└─────────────────────────────────────────────────────────────────────── |
ripatel-fd
force-pushed
the
ripatel/kernel-ci
branch
from
September 8, 2026 05:43
ba8eb4d to
9608fd5
Compare
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The new compatibility job currently cannot fail the workflow.
Review details
Suppressed comments (1)
.github/workflows/old_kernel_headers.yml:9
continue-on-errorprevents this workflow from failing when either the header installation ormake checkfails, so an old-header regression will still produce a successful PR check. Make this job blocking so the new compatibility check can enforce its result.
timeout-minutes: 5
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced
ripatel-fd
marked this pull request as draft
September 8, 2026 06:08
auto-merge was automatically disabled
September 8, 2026 06:08
Pull request was converted to draft
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.