Skip to content

conformance: build feature set once per input #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjain-jump merged 1 commit into from
Oct 13, 2026
Merged

conformance: build feature set once per input #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions svm/src/conformance/feature_set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

use {
agave_feature_set::{FEATURE_NAMES, FeatureSet},
ahash::{AHashMap, AHashSet},
protosol::protos::FeatureSet as ProtoFeatureSet,
solana_pubkey::Pubkey,
std::{collections::HashMap, sync::LazyLock},
Expand All @@ -28,11 +29,13 @@ static INDEXED_FEATURES: LazyLock<HashMap<u64, Pubkey>> = LazyLock::new(|| {

/// Build a `FeatureSet` from a protobuf feature set.
pub fn feature_set_from_proto(value: &ProtoFeatureSet) -> FeatureSet {
let mut feature_set = FeatureSet::default();
let mut active = AHashMap::default();
let mut inactive: AHashSet<Pubkey> = FEATURE_NAMES.keys().cloned().collect();
for id in &value.features {
if let Some(pubkey) = INDEXED_FEATURES.get(id) {
feature_set.activate(pubkey, 0);
inactive.remove(pubkey);
active.insert(*pubkey, 0);
}
}
feature_set
FeatureSet::new(active, inactive)
}