Repository navigation
deps: bump zip to 9.0.3 (all of 8.x is yanked) - #194
Open
sanghnkim-max wants to merge 1 commit into
Open
sanghnkim-max wants to merge 1 commit into
sanghnkim-max wants to merge 1 commit into
Conversation
zip-rs yanked every 8.x release (and 9.0.0-9.0.2), so a crate requiring ^8.6.0 resolves only to yanked versions and fails cargo-deny downstream. The releases since 8.6.0 fix symlink-following during extraction, decoder overflows and reads past an entry's declared size. Only ZipWriter and ZipArchive::by_name are used here, both unchanged in 9; tests pass as is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Confirming this fixes things downstream. Every zip 8.x release is yanked, so projects that depend on anydoc now fail Checked on this branch (3b829c6):
A 0.2.5 release with this change would be much appreciated. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip-rs has yanked every 8.x release, plus 9.0.0–9.0.2.
zip = "8.6.0"therefore resolves only to yanked versions, and downstream crates failcargo deny(error[yanked]) with no way to fix it from their side. The releases after 8.6.0 fix symlink-following during extraction, overflows in the implode decoder, and reads past an entry's declared size.This changes
Cargo.tomlandfuzz/Cargo.tomlto9.0.3and updates the lockfile. No code changes: anydoc only usesZipWriter,SimpleFileOptions,ZipArchive::new/by_nameandZipError::FileNotFound, and none of those changed in 9. zip 9.0.3 keepsrust-version = 1.88.cargo test --workspace(296 passed),cargo clippy --all-targets -- -D warningsandcargo fmt --checkare all clean. A release on this would let us drop our vendored copy.🤖 Generated with Claude Code
Summary by cubic
Bumps
zipfrom 8.6.0 to 9.0.3 so downstream crates can passcargo deny: all 8.x releases, plus 9.0.0–9.0.2, are yanked, leaving^8.6.0resolving only to yanked versions.No code changes are needed — the used APIs (
ZipWriter,SimpleFileOptions,ZipArchive::by_name) are unchanged in 9, andrust-versionstays at 1.88. The bump also picks up fixes for symlink-following during extraction, decoder overflows, and reads past an entry's declared size.Written for commit 3b829c6. Summary will update on new commits.