Repository navigation
test(fork): open the pinned-WAL reader just past the ceiling - #205
Merged
fireboltdude1357 merged 1 commit intoNov 6, 2026
Merged
fireboltdude1357 merged 1 commit into
fireboltdude1357 merged 1 commit into
Conversation
#204 moved readerAfter to 126, one row before the 32,768-frame ceiling. On omarchy, the Linux leg then held the write that crosses the ceiling. The old case opened the reader just after crossing it, so readerAfter is now 127. The TRUNCATE retry test keeps 126 because it needs the crossing write to run while the reader is open. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fork's nightly build fails on the Linux leg after #204:
It failed twice in a row on omarchy, where the Linux leg runs, and passed three times out of three on stl-wsl.
#204 scaled the pinned-WAL tests to upstream's 32,768-frame ceiling. The
readerAftercase used to open its reader after 39 rows, just past the old 10,000-frame ceiling. #204 set it to 126, which opens the reader one row before the new ceiling. That's a different case from the one this test was written for, and it holds the crossing write on omarchy's slower disk. Setting it to 127 opens the reader just after the ceiling, as the old 38 did.The TRUNCATE retry test keeps 126, because it needs the write that crosses the ceiling to run while the reader is open. Its comment now says so.
The 22 tests in
nodeSqliteClient.test.tspass twice in a row on stl-wsl with this change. The next fork build runs them on omarchy.The held write when a reader opens one row before the ceiling may be a real gap in the patch on slow disks. I haven't followed that up here.
Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code