Drop the ecdsa_preprocessing_data destructor (UB + heap leak)#54
Open
kozyilmaz wants to merge 1 commit into
Open
Drop the ecdsa_preprocessing_data destructor (UB + heap leak)#54kozyilmaz wants to merge 1 commit into
kozyilmaz wants to merge 1 commit into
Conversation
It cleansed sizeof(struct) from k.data (== this), zeroing the vector/map control blocks before their destructors ran -- UB, leaking the buffers. The scalars already self-wipe and the containers are public, so it's unneeded. Signed-off-by: kozyilmaz <kazim@monolytic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It cleansed sizeof(struct) from k.data (== this), zeroing the vector/map control blocks before their destructors ran -- UB, leaking the buffers. The scalars already self-wipe and the containers are public, so it's unneeded.
This has been brought up by @nkavian, I kept the proving tests in a separate branch not to pollute your codebase. The test that proves the leak/UB lives in this branch kozyilmaz@5cb0aac
The fix is tested on the system below:
This is the test and output in the other branch (kozyilmaz@5cb0aac):
After this one line fix the test is cleared: