Skip to content

fix(extensions): remove colliding -i short flag from ext:migrate --ext-instance option - #11057

Merged
shettyvarun268 merged 2 commits into
mainfrom
shettyvarun268/ext-migrate-remove-short-flag-i
Sep 9, 2026
Merged

fix(extensions): remove colliding -i short flag from ext:migrate --ext-instance option#11057
shettyvarun268 merged 2 commits into
mainfrom
shettyvarun268/ext-migrate-remove-short-flag-i

Conversation

@shettyvarun268

Copy link
Copy Markdown
Contributor

Description

In firebase ext:migrate, the --ext-instance <instanceId> option was registered with the short flag -i. However, -i, --interactive is globally registered across all CLI commands in src/index.ts.

Because Commander processes global options first, passing -i <instanceId> caused Commander to parse -i as the boolean --interactive flag, leaving the instance ID unconsumed or causing unexpected prompt behaviors/errors in scripted environments. Furthermore, --help actively advertised the broken -i short flag.

This PR removes the colliding -i short flag from ext:migrate, making --ext-instance <instanceId> the unambiguous option.

Scenarios Tested

  • Verified firebase ext:migrate --help displays --ext-instance <instanceId> without the conflicting -i shortcut.
  • Ran unit tests via mocha: npm test -- src/extensions/migrate.spec.ts (38/38 passing).
  • Verified migration runs cleanly with --ext-instance <instanceId>.

Sample Commands

firebase ext:migrate --ext-instance storage-resize-images --project my-project

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the short option -i from the --ext-instance option in the ext:migrate command. I have no feedback to provide as there are no review comments and the change is straightforward.

@shettyvarun268
shettyvarun268 marked this pull request as ready for review September 8, 2026 23:10
@shettyvarun268
shettyvarun268 merged commit ad45804 into main Sep 9, 2026
51 checks passed
@shettyvarun268
shettyvarun268 deleted the shettyvarun268/ext-migrate-remove-short-flag-i branch September 9, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants