fix(extensions): remove colliding -i short flag from ext:migrate --ext-instance option - #11057
Merged
shettyvarun268 merged 2 commits intoSep 9, 2026
Merged
Conversation
shettyvarun268
marked this pull request as ready for review
September 8, 2026 23:10
ajperel
approved these changes
Sep 9, 2026
shettyvarun268
deleted the
shettyvarun268/ext-migrate-remove-short-flag-i
branch
September 9, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
firebase ext:migrate, the--ext-instance <instanceId>option was registered with the short flag-i. However,-i, --interactiveis globally registered across all CLI commands insrc/index.ts.Because Commander processes global options first, passing
-i <instanceId>caused Commander to parse-ias the boolean--interactiveflag, leaving the instance ID unconsumed or causing unexpected prompt behaviors/errors in scripted environments. Furthermore,--helpactively advertised the broken-ishort flag.This PR removes the colliding
-ishort flag fromext:migrate, making--ext-instance <instanceId>the unambiguous option.Scenarios Tested
firebase ext:migrate --helpdisplays--ext-instance <instanceId>without the conflicting-ishortcut.npm test -- src/extensions/migrate.spec.ts(38/38 passing).--ext-instance <instanceId>.Sample Commands