-
Notifications
You must be signed in to change notification settings - Fork 431
fix(firestore-vector-search): remove the unimplemented multimodal provider value #3074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 0 additions & 30 deletions
30
kits/firestore-vector-search/src/embeddings/client/multimodal/index.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import { declaredParams } from "firebase-functions/params"; | ||
| import { describe, expect, test } from "vitest"; | ||
|
|
||
| import "../src/config"; | ||
| import { | ||
| type EmbeddingProvider, | ||
| resolveVectorSearchConfig, | ||
| } from "../src/export-config"; | ||
|
|
||
| describe("EMBEDDING_PROVIDER", () => { | ||
| test("the provider select does not offer multimodal", () => { | ||
| const param = declaredParams.find((p) => p.name === "EMBEDDING_PROVIDER"); | ||
| expect(param).toBeDefined(); | ||
|
|
||
| const input = param?.options.input; | ||
| if (!input || !("select" in input)) { | ||
| throw new Error("EMBEDDING_PROVIDER must be a select input"); | ||
| } | ||
|
|
||
| const values = input.select.options.map((option) => option.value); | ||
| expect(values).toEqual(["gemini", "openai", "vertex", "custom"]); | ||
| }); | ||
|
|
||
| test("resolving a config with the removed multimodal provider throws", () => { | ||
| expect(() => | ||
| resolveVectorSearchConfig({ | ||
| projectId: "demo-project", | ||
| instanceId: "test", | ||
| embeddingProvider: "multimodal" as unknown as EmbeddingProvider, | ||
| }) | ||
| ).toThrow( | ||
| 'Unsupported EMBEDDING_PROVIDER "multimodal". Set it to one of: gemini, openai, vertex, custom.' | ||
| ); | ||
| }); | ||
|
|
||
| test("every offered provider resolves", () => { | ||
| const providers: ReadonlyArray<EmbeddingProvider> = [ | ||
| "gemini", | ||
| "openai", | ||
| "vertex", | ||
| "custom", | ||
| ]; | ||
| for (const embeddingProvider of providers) { | ||
| const config = resolveVectorSearchConfig({ | ||
| projectId: "demo-project", | ||
| instanceId: "test", | ||
| embeddingProvider, | ||
| customEmbeddingsDimension: 256, | ||
| }); | ||
| expect(config.embeddingProvider).toBe(embeddingProvider); | ||
| expect(config.dimension).toBeGreaterThan(0); | ||
| } | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In strict TypeScript configurations, checking
!EMBEDDING_PROVIDERS.includes(embeddingProvider)whenembeddingProvideris already typed asEmbeddingProvidercan trigger a linter or compiler warning (such asno-unnecessary-condition) because the condition is statically determined to be always false. CastingEMBEDDING_PROVIDERStoreadonly string[]avoids this issue while preserving the runtime validation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declining. This kit runs no eslint (no config or dependency), so no-unnecessary-condition cannot fire, and tsc compiles Array.prototype.includes on the readonly tuple with a union-typed argument without complaint - CI is green on this code. The guard exists because embeddingProvider reaches here through casts from env strings, so the runtime check is not statically dead; widening the array to readonly string[] would only loosen the types the guard relies on.