Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions kits/storage-resize-images/src/handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,12 @@ export async function generateResizedImageHandler(
},
});

resizeFailed = resizeResults.some(
(result) =>
result.status === "rejected" || result.value.success === false
);
resizeFailed =
resizeResults.length === 0 ||
resizeResults.some(
(result) =>
result.status === "rejected" || result.value.success === false
);
}

const failed = filterErrored || resizeFailed;
Expand Down
23 changes: 23 additions & 0 deletions kits/storage-resize-images/tests/handlers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,29 @@ describe("generateResizedImageHandler", () => {
expect(handleFailedImage).toHaveBeenCalledTimes(1);
});

test("treats zero resize outputs as a failure", async () => {
const ctx = makeCtx();
mock(resizeImages).mockResolvedValue([]);

await generateResizedImageHandler(mockObject, ctx, false);

expect(logs.failed).toHaveBeenCalled();
expect(handleFailedImage).toHaveBeenCalledTimes(1);
});

test("keeps the original under on_success when no resize was produced", async () => {
mock(downloadOriginalFile).mockResolvedValue([
"/tmp/test.jpg",
{ delete: vi.fn() },
]);
mock(resizeImages).mockResolvedValue([]);
const ctx = makeCtx({ deleteOriginalFile: DELETE_IMAGE.onSuccess });

await generateResizedImageHandler(mockObject, ctx, false);

expect(deleteRemoteFile).not.toHaveBeenCalled();
});

test("deletes the original only after a successful run under on_success", async () => {
const remoteFile = { delete: vi.fn() };
mock(downloadOriginalFile).mockResolvedValue(["/tmp/test.jpg", remoteFile]);
Expand Down
Loading