Skip to content

Sync from abseil/abseil-cpp#32

Open
aslam9691 wants to merge 3 commits into
firebase:mainfrom
aslam9691:sync-20260526.0
Open

Sync from abseil/abseil-cpp#32
aslam9691 wants to merge 3 commits into
firebase:mainfrom
aslam9691:sync-20260526.0

Conversation

@aslam9691

@aslam9691 aslam9691 commented Jun 26, 2026

Copy link
Copy Markdown

upgrade the spm and added automation script for the future release
Sync from https://github.com/abseil/abseil-cpp/releases/tag/20260526.0

@aslam9691 aslam9691 marked this pull request as ready for review June 26, 2026 08:33

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant updates across the Abseil codebase, including the addition of new container types chunked_queue, linked_hash_map, and linked_hash_set, modernization of various utilities to use standard C++17/C++20 features (such as std::optional, std::variant, and std::source_location), and performance optimizations in hashing using hardware-accelerated CRC32 and AES instructions. It also refactors SymbolDecorator to be class-based and updates stack tracing and spinlock implementations. Feedback on the changes points out a redundant file exclusion in Package.swift where certain files are listed twice.

Comment thread Package.swift Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@aslam9691

Copy link
Copy Markdown
Author

@ncooke3 @cherylEnkidu Please review.

Comment thread Package.swift
@@ -50,8 +50,6 @@ let package = Package(
"absl/abseil.podspec.gen.py",
"absl/time/internal/cctz/src/time_zone_name_win.cc",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"absl/time/internal/cctz/src/test_time_zone_names.cc" can be added to the exclude list of the target in Package.swift

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants