Repository navigation
Multi-shard + mvexpand edge-case ITs for multi-value fields - #3
Closed
finnegancarroll wants to merge 1 commit into
Closed
finnegancarroll wants to merge 1 commit into
finnegancarroll wants to merge 1 commit into
Conversation
…e fields
Extends the multi-value keyword IT coverage exercised against the analytics engine:
- CalciteMultiValueDistributedIT (NEW): 2-shard tests that drive the coordinator
reduce / cross-shard FFI paths a single shard never triggers -
* cross-shard mvexpand group-by (per-element counts reduced across shards),
* PARTIAL/FINAL stage assertions via the profile API,
* backend-routing assertion (multi-value group-by executes on the analytics
engine / datafusion, not delegated to Lucene), and
* cross-shard stored-LIST projection (exercises the Utf8/Utf8View LIST-child
Arrow schema boundary).
- CalciteMultiValueKeywordOperatorIT: adds mvexpand edge cases (per-document
limit=N, single-element array).
- integ-test/build.gradle: run CalciteMultiValueDistributedIT on the AE cluster task.
These depend on two core (analytics-engine) changes:
- the mvexpand Correlate/Uncollect marking fix (finnegancarroll/OpenSearch, draft
opensearch-project/OpenSearch#23054), and
- Varun's multi-shard + LIST Arrow-schema fix (opensearch-project/OpenSearch#23040).
The multi-shard cases pass only with #23040 applied; without it the cross-shard
reduce crashes the data node on the LIST schema mismatch.
Signed-off-by: Finn Carroll <carrofin@amazon.com>
Owner
Author
|
Superseded: the multi-shard + mvexpand edge-case ITs are already included in the current MV stack (see #9). Closing as redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test only changes.
Expands the multi-value keyword-field integration-test coverage exercised against the analytics engine, adding multi-shard coverage that the existing single-shard suite could not reach, plus
mvexpandedge cases.Depends on core fix for multi shard AE group by
opensearch-project/OpenSearch#23091