Repository navigation
feat(drivercentral): a tag build's drivercentral artifact is the whole DriverCentral upload - #199
Merged
Merged
Conversation
…e DriverCentral upload
Contributor
There was a problem hiding this comment.
Approving. I ran the default render's build leg with a product card, two of the three banners, two photos and a photos/sources/ image committed into the render. make build and make verify pass, listing/ holds exactly those files with the missing banner left out and nothing from sources/, and the zip still contains only c4z/ and docs/. A manual run is safe for releases because Release only fires on a tag push and filters Build runs on --event push. A dispatch on a tag still gets the tag version stamp, REQUIRE_SECRETS and 14-day retention through ref_type == 'tag', and its own run_id concurrency group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DriverCentral upload needed files from two places. The build artifact had the driver zip, the PDFs and, since #193 and #195, the description and Revisions HTML. The product card, facts strip, banners and listing photos had to be fetched from
resources/drivercentral/. This puts all of it in the drivercentral artifact, so a tag build's download is the whole upload.What it does now
make buildwritesdist/drivercentral/listing/, beside<repo>.zip,c4z/anddocs/:description.htmlandrevisions.htmlmove fromdist/drivercentral/intolisting/. The zip still packs onlyc4z/anddocs/, so integrators' downloads are unchanged. An image a repo hasn't rendered yet is just left out.The Build workflow gains
workflow_dispatch. Tag artifacts last 14 days, and GitHub re-runs a run only within 30 days, so an older tag's upload can be rebuilt from the Actions tab by running Build on the tag. A manual run on a tag stamps the tag's date and keeps its artifact 14 days. Release only fires on a tag push, so it doesn't publish twice.Checked: the default render's render and build checks pass. With ESPHome's real images dropped into the render,
make buildwrites the listing above with all three banners, the four photos and no sources, and the zip holds onlyc4z/anddocs/.What reaches a driver repo
On
copier update, the Makefile,.github/workflows/build.ymland CONTRIBUTING change. The seededresources/drivercentral/README.mdis skip-if-exists, so only new repos get its updated paths.