Repository navigation
INTER-2456: Deprecate tag in favor of tags - #102
Merged
Merged
Conversation
kevinmia
requested review from
JuroUhlar,
TheUnderScorer and
ilfa
as code owners
October 23, 2026 19:19
Contributor
Coverage report
Test suite run success36 tests passing in 7 suites. Report generated by 🧪jest coverage report action from 061fbfc Show full coverage report
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The dependency and documentation updates fit the existing option-forwarding behavior, with no unresolved blocking findings.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
This PR aligns the Vue SDK with the cross-SDK move from tag to tags, while preserving legacy tag support and leaving option-forwarding logic unchanged.
Changes:
- Raises the minimum
@fingerprint/agentversion to 4.1.6 to exposetagsin its types. - Updates documentation examples and explains that
tagstakes precedence overtag. - Adds release notes and refreshes the dependency lockfile.
| File | Description |
|---|---|
src/useVisitorData/useVisitorData.ts |
Updates the JSDoc example to use tags; no runtime changes. |
README.md |
Documents tags, legacy support, and precedence. |
pnpm-lock.yaml |
Locks agent 4.1.6 and refreshes peer dependency resolutions. |
package.json |
Requires @fingerprint/agent ^4.1.6. |
.changeset/tags-option-support.md |
Adds a minor release note for the option deprecation. |
.changeset/bump-agent-version.md |
Adds a patch release note for the dependency bump. |
Review effort: Balanced
JuroUhlar
reviewed
Oct 26, 2026
JuroUhlar
previously approved these changes
Oct 26, 2026
Contributor
JuroUhlar
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last of the PRs as a part of INTER-2456. We're looking to standardize usage of
tagsacross SDKs.tagkeeps working, andtagswins if both are passed.Changes:
@fingerprint/agent4.1.6 or later sotagsis inGetOptionsuseVisitorDataJSDoc example to usetags, with a note in the README thattagis deprecatedLike Svelte (PR), there are no code changes.
useVisitorDatamerges its default options with the per-call options and passes them straight to the agent, sotagsalready works at runtime.The lockfile diff is bigger than the agent bump because pnpm 11 re-resolves the
supports-colorpeer when the lockfile is regenerated. The only real change in it is@fingerprint/agentgoing from 4.1.3 to 4.1.6.Testing:
tagtagstype-checks against the built packagetagsis passed through to the agent and overrides the default. Not added to the PR since existing tests already cover option pass-through withtag