Skip to content

INTER-2456: Deprecate tag in favor of tags - #102

Merged
kevinmia merged 2 commits into
mainfrom
chore/INTER-2456-standardize-tags
Oct 26, 2026
Merged

kevinmia merged 2 commits into
mainfrom
chore/INTER-2456-standardize-tags

Conversation

@kevinmia

@kevinmia kevinmia commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Last of the PRs as a part of INTER-2456. We're looking to standardize usage of tags across SDKs. tag keeps working, and tags wins if both are passed.

Changes:

  • Require @fingerprint/agent 4.1.6 or later so tags is in GetOptions
  • Update the README and the useVisitorData JSDoc example to use tags, with a note in the README that tag is deprecated

Like Svelte (PR), there are no code changes. useVisitorData merges its default options with the per-call options and passes them straight to the agent, so tags already works at runtime.

The lockfile diff is bigger than the agent bump because pnpm 11 re-resolves the supports-color peer when the lockfile is regenerated. The only real change in it is @fingerprint/agent going from 4.1.3 to 4.1.6.

Testing:

  • Existing tests pass, including the ones using tag
  • Checked that tags type-checks against the built package
  • Ran a local test confirming tags is passed through to the agent and overrides the default. Not added to the PR since existing tests already cover option pass-through with tag

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 100% 58/58
🟢 Branches 100% 24/24
🟢 Functions 100% 10/10
🟢 Lines 100% 58/58

Test suite run success

36 tests passing in 7 suites.

Report generated by 🧪jest coverage report action from 061fbfc

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 100 100 100 100
🟢  src 100 100 100 100
🟢   client.ts 100 100 100 100
🟢   config.ts 100 100 100 100
🟢   plugin.ts 100 100 100 100
🟢   symbols.ts 100 100 100 100
🟢   utils.ts 100 100 100 100
🟢  src/mixins 100 100 100 100
🟢   mixins.ts 100 100 100 100
🟢  ...useVisitorData 100 100 100 100
🟢   ...isitorData.ts 100 100 100 100

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The dependency and documentation updates fit the existing option-forwarding behavior, with no unresolved blocking findings.

No open issues 🎉

1 file not reviewed
  • pnpm-lock.yaml: Generated file
What changed in this PR

This PR aligns the Vue SDK with the cross-SDK move from tag to tags, while preserving legacy tag support and leaving option-forwarding logic unchanged.

Changes:

  • Raises the minimum @fingerprint/agent version to 4.1.6 to expose tags in its types.
  • Updates documentation examples and explains that tags takes precedence over tag.
  • Adds release notes and refreshes the dependency lockfile.
File Description
src/​useVisitorData/​useVisitorData.ts Updates the JSDoc example to use tags; no runtime changes.
README.md Documents tags, legacy support, and precedence.
pnpm-lock.yaml Locks agent 4.1.6 and refreshes peer dependency resolutions.
package.json Requires @fingerprint/agent ^4.1.6.
.changeset/​tags-option-support.md Adds a minor release note for the option deprecation.
.changeset/​bump-agent-version.md Adds a patch release note for the dependency bump.

Review effort: Balanced

Comment thread README.md Resolved
JuroUhlar
JuroUhlar previously approved these changes Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

@fingerprint/vue@2.1.0

Minor Changes

  • Deprecate tag in favor of tags (15a910e)

Patch Changes

  • Bump @fingerprint/agent dependency to ^4.1.6 (15a910e)

@kevinmia
kevinmia requested a review from JuroUhlar October 26, 2026 12:13
@kevinmia
kevinmia merged commit 6d6b74a into main Oct 26, 2026
11 checks passed
@kevinmia
kevinmia deleted the chore/INTER-2456-standardize-tags branch October 26, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants