Repository navigation
INTER-2622: Derive podspec Fingerprint-iOS version from Package.swift - #285
Merged
Merged
Conversation
kevinmia
requested review from
a team,
TheUnderScorer,
ilfa and
necipallef
as code owners
October 8, 2026 22:27
Contributor
Coverage report
Test suite run success95 tests passing in 6 suites. Report generated by 🧪jest coverage report action from d92572c Show full coverage report
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The version regex can silently select an unrelated package requirement.
1 open finding
What changed in this PR
Derives the CocoaPods Fingerprint-iOS range from the SwiftPM manifest.
Changes:
- Reads the lower version from
Package.swift. - Computes the next-minor upper bound.
- Applies the derived range to the pod dependency.
| File | Description |
|---|---|
sdk/RNFingerprint.podspec |
Synchronizes the CocoaPods dependency range with SwiftPM. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TheUnderScorer
previously approved these changes
Oct 9, 2026
Contributor
pnpm exec changesetto create a changeset. |
TheUnderScorer
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Ticket: https://fingerprintjs.atlassian.net/browse/INTER-2622
Mirroring the approach in the Flutter SDK's podspec. Note that the regex also tolerates the multi-line
.package(...)layout used insdk/Package.swift.Testing: Temporarily set
Package.swiftto 4.2.3, where it resolved to>= 4.2.3, < 4.3.0.