Repository navigation
Conversation
Contributor
pnpm exec changesetto create a changeset. |
Contributor
|
🟢 Coverage increased by 97.53% Code Coverage ReportCoverage Report
Files Coverage
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | koala#18895 |
searchEventsorder fix: koala#18934 | schema from openapi#494 @78d51f2Why
This checks that the PHP SDK, which moves from
fingerprint-server-api-v4.yaml(now the union) to the new flattenedfingerprint-server-api-v4-flat.yaml, regenerates with no breaking change from theEventsplit.Things to note
Eventsplit.Eventis still one class,sourceis still an optional?EventSourcewith the same getter and setter, and no classes, serializers or validators change. 931 tests pass and php-cs-fixer is clean.searchEventsarguments back toactive_call, source. Commit1a0e542eon main fixed the order by hand-editingres/fingerprint-server-api.yaml, but koala and the published schema still haveactive_callfirst. koala#18934 movessourceback aboveactive_callin koala's schema. This is visible in the baseline commit, and #494 doesn't cause it.Change outline
Commits, so the
Eventchange can be reviewed on its own:1d17e6dagainst the baseline:Baseline
searchEventsswap (the separate bug, fixed in koala#18934):New tests (
test/Api/FingerprintApiTest.php):