Repository navigation
OpenAPI schema sync (v3.9.0) - #287
Merged
Merged
Conversation
fingerprint-dx-team-actions-runner
Bot
requested review from
Orkuncakilkaya,
TheUnderScorer,
erayaydin and
ilfa
as code owners
October 8, 2026 15:38
Contributor
|
🟢 Coverage increased by 97.53% Code Coverage ReportCoverage Report
Files Coverage
|
Reorder operation parameters in a temporary copy of the schema before generation, so `active_call` stays the last `searchEvents` parameter and positional callers do not break.
Move the `active_call` parameter after `source` in `res/fingerprint-server-api.yaml` so the generated `searchEvents` signature stays backward compatible.
ilfa
reviewed
Oct 9, 2026
erayaydin
previously approved these changes
Oct 9, 2026
erayaydin
left a comment
erayaydin
left a comment
Member
There was a problem hiding this comment.
LGTM. We have 504 tests but the new 503 responses don't have any tests (with using 503_service_unavailable.json) but i think thats okay.
Contributor
🚀 Following releases will be created using changesets from this PR:@fingerprint/php-sdk@7.8.0-beta.0Minor Changes |
erayaydin
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema sync for v3.9.0 OpenAPI schema release.
Ticket: INTER-2637