Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 35345bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Schema Diff vs Published Schemas
|
Contributor
🚀 Following releases will be created using changesets from this PR:openapi@3.10.0Minor Changes
Patch Changes
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | CORE-783 | koala#18895 @
e650844| stacked: #494Why
Edge and device events share one flat
Event, so nothing tells SDK users or AI agents that edge events never haveidentification. This PR syncs koala'sEventDevice | EventEdgeunion so the schema says it.Things to note
Event.minor. In the Node SDK, code that readsevent.identificationwithout first checkingsourcestops compiling. Push back if this should bemajor.Change outline
The schema now has one
Eventwith two variants.sourceis required on both.Endpoints:
GET /events/{event_id} → Event (now the union) GET /events → EventSearch { events: Event[] } - POST /edge → EdgeResponse + POST /edge → EventEdge webhook → EventFiles:
The changes were produced by running
action-openapi-synclocally against the koala PR head. The action copies only files reached through a$ref, sowebhook_event.json, which isn't referenced but is validated againstEvent, was copied by hand.