Skip to content

chore: add prep sync changesets with gh API put - #479

Merged
mcnulty-fp merged 2 commits into
mainfrom
chore/INTER-2582-sign-sync-prep-commits
Sep 23, 2026
Merged

mcnulty-fp merged 2 commits into
mainfrom
chore/INTER-2582-sign-sync-prep-commits

Conversation

@mcnulty-fp

@mcnulty-fp mcnulty-fp commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor
  • Change the Commit changeset(s) step in the ai-prep-sync-pr to use the gh API to put each changeset individually. This results in the commits created by the PR to be signed.

I went with this approach because there's usually just a few changesets and this seemed simpler than pulling in another action to do the commit. Additionally, I couldn't find any widely-used actions for creating signed commits using the API (and as a result, not requiring GPG key management).

Should fix the failure first seen in #478

- Change the `Commit changeset(s)` step in the `ai-prep-sync-pr` to
  use the gh API to put each changeset individually. This results in
  the commits created by the PR to be signed.
@mcnulty-fp
mcnulty-fp requested a review from a team as a code owner September 23, 2026 19:59
@changeset-bot

changeset-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7f7b438

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcnulty-fp
mcnulty-fp changed the base branch from sync-18599 to main September 23, 2026 19:59
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Schema Diff vs Published Schemas

  • Generated at: 2026-09-23T20:48:00.883Z
  • Published source: https://fingerprintjs.github.io/fingerprint-pro-server-api-openapi/schemas
  • Compared schemas: 8
  • Changed schemas: 0

No schema changes detected between local build output and published GitHub Pages schemas.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The new logic silently ignores tracked changeset modifications and deletions.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Replaces local changeset commits with GitHub Contents API calls so commits are signed.

Changes:

  • Uploads each detected changeset individually.
  • Targets the PR head branch with base64-encoded content.
File Description
.github/​workflows/​ai-prep-sync-pr.yml Replaces local commit/push logic with API uploads.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ai-prep-sync-pr.yml
kevinmia
kevinmia previously approved these changes Sep 23, 2026

@kevinmia kevinmia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just left a minor, non-blocking comment

Comment thread .github/workflows/ai-prep-sync-pr.yml
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm run changeset

to create a changeset.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change correctly addresses signed-commit enforcement without unresolved issues.

Review effort: Balanced
Findings: None

Resolved since last review (1)

@mcnulty-fp
mcnulty-fp merged commit 55bbe16 into main Sep 23, 2026
7 checks passed
@mcnulty-fp
mcnulty-fp deleted the chore/INTER-2582-sign-sync-prep-commits branch September 23, 2026 20:59

This branch was successfully deployed

1 active deployment
test — 7f7b4383 Deployed Sep 23, 2026 by mcnulty-fp via Lint, build and test #1442
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants