Repository navigation
Conversation
Contributor
pnpm exec changesetto create a changeset. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | koala#18895 | schema from openapi#494 @
78d51f2Why
Check that the flat
Eventbuilt for Java by openapi#494 does not change the generated Java SDK in a breaking way.Things to note
EventJavadoc. All 100 compiled classes insdk/build/classes/java/mainare byte-identical between the baseline commit and the 78d51f2 commit (diff -r).Event.sourceis still a nullableEventSourcewith the same getter, setter, builder method andUNSUPPORTED_VALUE_SDK_UPGRADE_REQUIREDfallback. No new or removed classes. TheEnvironmentIdkey move changes nothing in the Java output, so no order-sensitive API (fields, constructors,@JsonPropertyOrder) moved../gradlew buildpasses (107 tests, 3 new). The new tests cover an event with nosource(getSource()is null, not written back on serialization), an edge event (source: edge, noidentification), and an unknownsourcevalue. The edge mock was already deserialized by the existing tests, but they only checkedevent_idandtimestamp.mocks/errors/504_search_timeout_exceeded.json. The 78d51f2 commit also refreshesmocks/webhook/webhook_event.json(addssource: "device"and more fields); that example change comes from the stacked openapi#493, not from theEventsplit.docs/Event.mdand the Javadoc render the new multi-line description as one line, so the bullet list is flattened.Change outline
Three commits, so the
Eventchange is its own diff:The baseline commit is the sync workflow run on the published schema and examples. The generated code is identical to
main, so the baseline brings only one new example. The second commit is the same sync on the 78d51f2 build. Generated diff of that commit:New tests, in
SerializationTest: