Repository navigation
INTER-2472: Update schema URL in sync script - #55
Merged
Merged
Conversation
Update OpenAPI schema URL in the sync script. Extract the base URL into `defaultBaseUrl` with positional overrides. Use `env bash` shebang, so the script picks up bash from the correct environment. Resolve paths relative to the repository root. Harden `curl` with retry transient failures, refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hand CI or local. Rename `examplesList` to `examples`, log the full URL being fetched rather than just the example path, so it is clear which base URL a run actually used. Update the OpenAPI repository link in the `contributing.md` file. Related-Task: INTER-2472
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The required upstream rename PR remains open and merging now would break schema downloads.
Review effort: Balanced
Findings: None
What changed in this PR
Updates schema synchronization for the planned OpenAPI repository rename and improves script reliability.
Changes:
- Uses the renamed repository’s schema and examples URLs.
- Adds configurable URLs, retries, timeouts, and repository-relative paths.
- Updates the contributing guide repository link.
| File | Description |
|---|---|
scripts/sync.sh |
Updates download URLs and hardens synchronization. |
contributing.md |
Points contributors to the renamed repository. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
pnpm exec changesetto create a changeset. |
erayaydin
marked this pull request as ready for review
September 25, 2026 09:04
erayaydin
requested review from
Orkuncakilkaya,
ilfa,
mcnulty-fp and
necipallef
as code owners
September 25, 2026 09:04
Orkuncakilkaya
approved these changes
Sep 25, 2026
erayaydin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so
sync.shwill start failing with a 404. This PR changes the default OpenAPI schema URL.Alongside the URL change, the base URL moves into
defaultBaseUrlwithschemaUrl/examplesBaseUrlpositional overrides. Useenv bashshebang, so the script picks up bash from the correct environment. Resolve paths relative to the repository root. Hardencurlwith retry transient failures, refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hand CI or local. RenameexamplesListtoexamples, log the full URL being fetched rather than just the example path, so it is clear which base URL a run actually used.Update the OpenAPI repository link in the
contributing.mdfile.