Skip to content

refactor: use new package structure for v4 server API - #4

Merged
mcnulty-fp merged 6 commits into
mainfrom
fix/INTER-1824-package-structure
Feb 27, 2026
Merged

mcnulty-fp merged 6 commits into
mainfrom
fix/INTER-1824-package-structure

Conversation

@mcnulty-fp

Copy link
Copy Markdown
Contributor
  • Update all Java code to use the base package of com.fingerprint.v4. This will allow SDK users to perform a soft migration from v3 to v4.

- Update all Java code to use the base package of `com.fingerprint.v4`.
  This will allow SDK users to perform a soft migration from v3 to v4.
Comment thread sdk/src/main/java/com/fingerprint/v4/model/AbstractOpenApiSchema.java Outdated

@ilfa ilfa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, why readme wasn't updated, we have examples in it that should be updated.
Same question about other documentation files

@mcnulty-fp

mcnulty-fp commented Feb 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Interesting, why readme wasn't updated, we have examples in it that should be updated. Same question about other documentation files

I forgot to update the templates, thanks for catching that! Templates updated with de7fd79

I should've done a grep after the builds were passing. I just did:

rg 'com\.fingerprint\.' | grep -v v4

and that only shows:

examples/src/main/java/com/fingerprint/example/FunctionalTests.java:package com.fingerprint.example;
examples/src/main/java/com/fingerprint/example/WebhookSignatureSample.java:package com.fingerprint.example;
examples/src/main/java/com/fingerprint/example/SealedResults.java:package com.fingerprint.example;
examples/examples.gradle.kts:    mainClass = "com.fingerprint.example.FunctionalTests

which is what I would expect if the migration was complete.

EDIT:
I also just ran:

rg 'com/fingerprint/' | grep -v v4 | grep -v '/example/'

And that showed no results, which is what I would expect.

@mcnulty-fp
mcnulty-fp requested a review from ilfa February 26, 2026 15:42
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Following releases will be created using changesets from this PR:

java-sdk@8.0.0-rc.1

Patch Changes

  • Change root package from com.fingerprint to com.fingerprint.v4 (7ba8295)

@ilfa

ilfa commented Feb 27, 2026 •

Copy link
Copy Markdown
Member

Interesting, why readme wasn't updated, we have examples in it that should be updated. Same question about other documentation files

I forgot to update the templates, thanks for catching that!

Oh, we have a package name hardcoded in the readme template! I expected it to be generated, thanks!

@mcnulty-fp
mcnulty-fp merged commit a1de20a into main Feb 27, 2026
11 of 12 checks passed
@mcnulty-fp
mcnulty-fp deleted the fix/INTER-1824-package-structure branch February 27, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants