Repository navigation
Conversation
Regenerated from fingerprint-server-api-v4-normalized.yaml built from fingerprintjs/openapi@78d51f2. Adds a test for unmarshalling events without source and with source: edge.
Contributor
pnpm exec changesetto create a changeset. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | koala#18895 | schema from openapi#494 @
78d51f2Why
This checks that the Go SDK, which reads the flattened
fingerprint-server-api-v4-normalized.yaml, regenerates with no breaking change once koala splitsEventintoEventDevice | EventEdge.Things to note
Eventdoc comment. Fields, types, tags,omitempty, constructors and unmarshalling are unchanged, andSourceis still*EventSource.go build,go vetand the full test suite pass.EnvironmentIdmoved earlier among the schema components. No effect on the generated code.Change outline
Generated model (
internal/openapi/model_event.go):New test (
test/EventSource_test.go):Files: