Repository navigation
INTER-2472: Update schema URL and harden sync script - #107
Merged
Merged
Conversation
Update the OpenAPI schema URL. Use an `env bash` shebang so the script picks up bash from PATH rather than whatever sits at /bin/bash. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect the curl flags into `CURL_OPTS`, gated on `TRACE` and `ACTIONS_STEP_DEBUG` so runs can be made verbose, and harden them: retry transient failures, refuse redirects that leave https, and bound connect and transfer time so a stalled download cannot hang CI or a local run. Log the schema download, which was previously silent. Fix `contributing.md` referring to `/bin/sync.sh`, an absolute path to the root filesystem, rather than `./bin/sync.sh`. Related-Task: INTER-2472
Contributor
pnpm exec changesetto create a changeset. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Quiet curl mode currently suppresses diagnostics when downloads fail.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: None
What changed in this PR
Updates schema synchronization for the renamed OpenAPI repository and improves script reliability.
Changes:
- Updates the default schema URL.
- Makes downloads path-independent, retryable, and time-bounded.
- Corrects sync-script paths in contributor documentation.
| File | Description |
|---|---|
bin/sync.sh |
Hardens and relocates schema downloads. |
contributing.md |
Corrects sync-script references. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
erayaydin
marked this pull request as ready for review
September 25, 2026 09:05
erayaydin
requested review from
TheUnderScorer,
ilfa,
kevinmia,
mcnulty-fp and
necipallef
as code owners
September 25, 2026 09:05
mcnulty-fp
approved these changes
Sep 25, 2026
erayaydin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so
sync.shwill start failing with a 404. This PR changes the default OpenAPI schema URL.Alongside the URL change, use
env bashshebang, so the script picks up bash from the correct environment. Resolve paths relative to the repository root, so the script no longer writes into whatever directory it is invoked from. Collect thecurlflags intoCURL_OPTS, gated onTRACEandACTIONS_STEP_DEBUGso runs can be made verbose, and harden them with retry transient failures, refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hang CI or local. Log the schema download, which was previously silent.contributing.mdreferred to/bin/sync.shin two places, an absolute path to the root filesystem rather than./bin/sync.sh. This is pre-existing and unrelated to the rename.