Skip to content

INTER-2472: Update schema URL and harden sync script - #154

Merged
erayaydin merged 2 commits into
mainfrom
chore/openapi-repo-rename-inter-2472
Sep 29, 2026
Merged

erayaydin merged 2 commits into
mainfrom
chore/openapi-repo-rename-inter-2472

Conversation

@erayaydin

@erayaydin erayaydin commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

GitHub redirects repository URLs after a rename but explicitly not project GitHub Pages URLs, so sync.sh will start failing with a 404. This PR changes the default OpenAPI schema URL.

Alongside the URL change, the base URL moves into a new var with positional overrides. Use env bash shebang, so the script picks up bash from the correct environment. Resolve paths relative to the repository root. Harden curl with retry transient failures, refuse redirects that leave https and bound connect and transfer time so a stalled download cannot hand CI or local. Log the full URL being fetched, so it is clear which base URL a run actually used.

Update OpenAPI schema URL in the sync script.

Use `env bash` shebang, so the script picks up bash from the correct
environment. Resolve paths relative to the repository root. Harden `curl`
with retry transient failures, refuse redirects that leave https and
bound connect and transfer time so a stalled download cannot hang CI or
local. Log the full URL being fetched, so it is clear which base URL
a run actually used.

Related-Task: INTER-2472

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The documented sh invocation is incompatible with the newly introduced Bash-only syntax.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity

Open (1)
What changed in this PR

Updates schema synchronization for the pending upstream repository rename and improves download reliability.

Changes:

  • Uses the renamed schema URL with positional override support.
  • Adds path resolution, retries, timeouts, protocol restrictions, and logging.
  • Enables stricter Bash error handling.
File Description
scripts/​sync.sh Hardens and updates schema downloading.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/sync.sh
@erayaydin
erayaydin requested a balanced review from Copilot September 24, 2026 18:24
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The default curl configuration suppresses actionable failure diagnostics.

Review effort: Balanced
Findings: None

Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Preserve curl error diagnostics when suppressing progress output

scripts/​sync.sh:12

Adding -s without -S suppresses curl's error diagnostics, so ordinary CI/local failures (for example, HTTP, TLS, or timeout errors) exit nonzero without explaining the cause. Keep the progress meter quiet while preserving errors by using -sS.

@erayaydin
erayaydin marked this pull request as ready for review September 25, 2026 09:03
@erayaydin erayaydin changed the title [DO NOT MERGE] INTER-2472: Update schema URL and harden sync script INTER-2472: Update schema URL and harden sync script Sep 29, 2026
@erayaydin
erayaydin merged commit b3368c3 into main Sep 29, 2026
16 checks passed
@erayaydin
erayaydin deleted the chore/openapi-repo-rename-inter-2472 branch September 29, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants