Repository navigation
Conversation
…ine) Reproduces the sync workflow against the currently published fingerprint-server-api-v4-normalized.yaml. Schema and generated code are unchanged; only examples that were missing from the repo are added.
Schema from fingerprint-server-api-v4-normalized.yaml built at fingerprintjs/openapi@78d51f2, filtered to the .NET SDK scopes, then regenerated with generate.sh.
|
Contributor
pnpm exec changesetto create a changeset. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Schema review prototype, do not merge. This is to test the schema
Eventsplit (EventDevice | EventEdge) as part of reviewing koala#18895.INTER-2457 | koala#18895 | schema from openapi#494 @
78d51f2Why
To check that the flattened
Eventthat openapi#494 builds for .NET changes nothing for SDK users, at compile time or at runtime.Things to note
Event.csanddocs/models/Event.md. TheEvent(constructor, all properties,EventSourceand its JSON converter, andFingerprintApiare byte-identical.dotnet buildis clean (0 errors), and all 91 tests pass, including 2 new ones that also pass on the baseline.Event.descriptionandEnvironmentIdmoving earlier undercomponents/schemas. Since the generator takes property order fromEvent.properties(unchanged), the positional constructor (the dotnet-sdk#201 risk) did not move.400_edge_ip_required,400_edge_unknown_field,400_request_read_timeout,413_payload_too_large,get_event_with_edge_200), andwebhook_event.jsonin the 78d51f2 build is a richer example than the v3.9.0 release. No test readswebhook_event.json.Change outline
Commits:
48d8fc8baseline: sync of the published v3.9.0 normalized schema and examples (schema and generated code unchanged, examples added)80b1ce9sync of the 78d51f2 schema and examples, regenerated withgenerate.she2e4e94testsConstructor of
Event, before and after (identical):The only generated change (
Event.cs):New tests in
FingerprintApiTests.cs:GetEventWithoutSourceAsyncTest:get_event_200.jsonwithsourceremoved deserializes intoEvent,Sourceis null and not set,Identificationis present.GetEdgeEventAsyncTest:get_event_with_edge_200.json(source: edge, no identification) deserializes intoEventwithSource == EventSource.EdgeandIdentification == null.Files: