v2.11.1 - #3
Merged
Merged
Conversation
… cld.web.wasm from:
- wasm/browser-entry.js: export setWasmModuleOptions({ locateFile }), stored module-level and passed to createCldModule() -- Emscripten's own glue already checks Module["locateFile"] before falling back to its bundled-relative-URL default, so this is purely additive
- index.d.ts: types for the new export
- README.md: document the override for bundlers that serve cld.web.wasm from a non-default path
- fix browser-entry.js's metadata.json import to use the `with { type: 'json' }` attribute Node's ESM loader requires -- without it the real browser entry point couldn't be loaded via plain Node import() at all, which is what made it impossible to test
- test/runner-wasm-browser.js: confirms the override is actually honored, not just accepted -- spawns the real browser-entry.js in a child process with no override (fails, since the default WASM URL resolves to a file:// URL that Node's fetch() can't handle) and again with locateFile pointed at a local HTTP server serving the real wasm binary (succeeds with a correct detection), so success in the second case can only come from the override taking effect
- package.json: add the new test to npm test
- add a fork changelog with entries for 2.11.0 and unreleased changes
- add read-only permissions to ci and security workflows - rename branches from `master` to `main` in security workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
setWasmModuleOptions({ locateFile })in the browser entry point, letting bundlers/apps overridewhere the WASM backend fetches
cld.web.wasmfrom when it isn't served at the default relativepath.
Fixed
metadata.jsonimport now uses thewith { type: 'json' }attributerequired by Node's ESM loader.
Security
codeql.yml) analyzing theactions,c-cpp, andjavascript-typescriptlanguages on push/PR tomainand weekly on a schedule.security.ymlworkflow runningnpm audit --audit-level=highagainst the package'snpm dependencies on push/PR to
mainand weekly on a schedule, separate from the CodeQLworkflow above.
GITHUB_TOKENpermissions tocontents: readon theci.ymlandsecurity.ymlworkflows.