Repository navigation
fix: preserve scalar MakeMaker test rules - #1964
Merged
Merged
Conversation
Return the generated test rule as a string when MY::test calls SUPER::test in scalar context, while retaining the existing split list return. Add a regression test for scalar-context wrappers that edit the inherited TEST_FILES command, and document the compatibility fix. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Bring the PR branch up to current master and preserve both changelog entries. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MY::testrule as a string in scalar context while keeping the existing list-context return.SUPER::testand edit$(TEST_FILES).This covers a scalar-returning
MY::testwrapper shape not covered by the list-context fix in #1660, following up on #1658.Validation
2Makefile line andmake: *** missing separator.nice -n 19 make: passed, including the new test (0 failures/errors in each Perl unit shard).nice -n 19 make check-links: passed.