Repository navigation
fix: don't emit duplicate entries for First/Last ranges in prop.c - #211
Merged
Merged
Conversation
The ", Last>" branch of MakeCLib extended the range but then fell through and also pushed a one-point entry for the last code point, which also kept the next block from merging. Regenerated prop.c: 2462 -> 2440 entries, same lookup results. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeCLib now emits a single entry for each
<..., First>/<..., Last>range inprop.c. Before, the", Last>"branch extended the range and then also pushed a one-point entry for the last code point, which kept following blocks with the same data from merging. The regenerated table shrinks from 2462 to 2440 entries, lookup results are unchanged for every code point, and TestTables passes.Co-authored-by: Claude Opus 5.5 noreply@anthropic.com