Repository navigation
fix: CD and toolchain workflow fixes from the cell template - #20
Merged
Merged
Conversation
The CD pipeline merged lakefile.toml textually with -X ours, which drops main's changes whenever they touch lines next to nightly-testing's dependency revisions. Now take main's lakefile.toml and only carry over nightly-testing's dependency revisions. When the lakefile changes, refresh the manifest with `lake update` on the nightly toolchain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`github.head_ref` is empty on push events, so every CD run shared the group `cd-`. Use `github.ref` so main and nightly-testing runs no longer queue behind (or cancel pending runs of) each other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The PR branch was named after the toolchain version, so each new release candidate opened a new PR and left the previous one open. Use a fixed branch so the existing PR is updated in place instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings over the CD/toolchain workflow fixes from the Batteries cell template. When main is merged into nightly-testing, nightly-testing now takes main's
lakefile.tomland keeps only its ownrevfor each[[require]](and its own toolchain and manifest), runninglake updateon the nightly toolchain if the lakefile changed. The main toolchain update now always uses oneupdate-main-toolchainbranch, so a new release candidate updates the open PR instead of opening another one. Where the CD concurrency group was keyed ongithub.head_ref(empty on push), it is now keyed ongithub.ref.Co-authored-by: Claude Opus 5.5 noreply@anthropic.com