refactor(app-runner): remove the legacy default-resource reuse from outputs - #589
Merged
Merged
Conversation
…utputs Copied outputs always register a new resource now, instead of recycling the pending placeholder resource that the legacy wrapper creator pre-created on the workunit. The current submitter creates no such placeholder, so this was already a no-op for apps submitted through it. Closes #361
Contributor
📝 "TODO" Changes DetectedSummary: ✅ 2 "TODO"s removed ✅ Removed "TODO"s (2)
This comment is automatically updated when "TODO" changes are detected. |
leoschwarz
force-pushed
the
refactor/remove-default-resource-hack
branch
from
August 12, 2026 10:35
1e2034a to
533fe49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pendingplaceholder resource that the legacy wrapper creator pre-created is no longer recycled. The current submitter never creates one, so this was already a no-op for apps it submits.reuse_default_resourceapp-spec field and the--reuse-default-resource/--no-reuse-default-resourceCLI options; anapp.ymlstill setting the field keeps working (the key is ignored, not rejected).pendingplaceholder next to the real outputs; slurmworker's four compat-path apps are tracked in proteomics/slurmworker#24.Closes #361
🤖 Prepared with assistance from Claude Opus 5 via Claude Code.