Repository navigation
backlog: gate slots without sshdt was closed by b7a576cdd; aplay's skip filed - #45
Merged
Merged
Conversation
… filed The row "Gate slots without sshdt (2026-10-18)" asked that test-init build the sshdt it needs instead of failing on a slot that had none. That was done on 2026-10-25 in b7a576c: ssh::test_server, which test-init's socket-activation boot calls (init.rs, its only use of sshdt), runs apps::build_unless_built(arch, "sshdt") before it takes the package, and says why in a comment. The commit is the desktop portal's, so the row was never closed. Deleted. Its place takes the same kind of slot dependence, still open: test-audio's fourth boot (audio.rs, test_aplay) is skipped, with a line, where alsa-lib and alsa-utils are not built, and the row passes, so whether aplay is checked depends on the slot. Not changed here: building them inside the gate would build two C ports in every test-audio run, CI's included, which is the product owner's to weigh. Checks: cargo xtask check-docs passes. Certification: none needed, a BACKLOG change only.
Contributor
|
For commit 5e4cdbe. Supply-chain flagsRead each before approving. These are places to look, not verdicts. blob (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The BACKLOG row "Gate slots without sshdt (2026-10-18)" asked that
test-initbuild the sshdt it needs. That already happened on 2026-10-25 in b7a576c:ssh::test_server, the only placetest-inittakes sshdt, callsapps::build_unless_built(arch, "sshdt")first. That commit was the desktop portal's, so nobody closed the row. This PR deletes it.In its place, a new row for the same kind of slot dependence, still open:
test-audio's aplay boot (audio.rs,test_aplay) is skipped, with a printed line, whenalsa-lib/alsa-utilsaren't built, and the row still passes. I didn't change the code: building them inside the gate would add two C-port builds to everytest-audiorun, CI's included, and that's the product owner's call.Checks
cargo xtask check-docspasses.Certification: none needed; BACKLOG only.
Generated by Claude Code