Repository navigation
Alerting smoke: do not rely on which evaluation reopens the alert - #29
Merged
Merged
Conversation
The check 'the very next evaluation reopens the alert' failed intermittently (expected 1, got 0) because the alerting scheduler also evaluates every few seconds and could reopen the alert between the window being cancelled and this call. It now evaluates and waits for the state, like the other checks of this smoke. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGkuYAYk2roQuWqY7hmBWs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check
the very next evaluation reopens the alertfailed intermittently on master and on PRs (expected 1, got 0; two of the last four master runs): the alerting scheduler evaluates every few seconds too, so after the maintenance window is cancelled it can reopen the alert before the smoke's own evaluation, which then reports 0 reopened. The smoke's own header says a check must never rely on what one evaluation did. It now evaluates and waits for the state (OPEN, reopened twice), in bash and in PowerShell; the next check still proves it was reopened exactly once more.Syntax-checked (bash -n, the .ps1 compiles); the check itself needs the health-test profile, so it is proved by this PR's e2e.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PGkuYAYk2roQuWqY7hmBWs