Repository navigation
Alert on late purchase orders (stacked on #27; needs alerting PR and procurement PR #1) - #28
Merged
Merged
Conversation
… smokes Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PGkuYAYk2roQuWqY7hmBWs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose: the alerting service knows procurement (PROCUREMENT_SERVICE_URL). The Enterprise starter pack gets a rule for the new source (Enterprise now 9 rules). Promises smoke section 10 (13 checks): an order not late opens nothing, three days past its expected day opens one alert and one incident with the fixed code PURCHASE_ORDER_LATE and no vendor or item, receiving everything resolves it, and cancelling a late order resolves its alert. Verified live: promises smoke 68 checks in bash and pwsh, starter pack 18 in both.
Stacked on #27 (base is its branch). Merge #27 first; GitHub then retargets this PR to master. The e2e clones alerting and procurement from master, so merge alerting and procurement #1 before this.
The smoke moves the expected day of a placed order back in the store (docker exec on the MongoDB container) and approves orders on the REAL approval service.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PGkuYAYk2roQuWqY7hmBWs