Prevent "undefined index" notice if $parts array is empty in Index\Index#removeIndexedDefinition#750
Open
asccc wants to merge 1 commit into
Open
Prevent "undefined index" notice if $parts array is empty in Index\Index#removeIndexedDefinition#750asccc wants to merge 1 commit into
asccc wants to merge 1 commit into
Conversation
If `$level` reaches 0, `array_slice($parts, 0, $level)` returns an empty array. This will issue a "undefined index notice" in the next recursion on `$part = $parts[$level]`. This notice gets transformed to an ErrorException which will cancel further analysis.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
============================================
- Coverage 82.12% 82.09% -0.03%
- Complexity 935 936 +1
============================================
Files 44 44
Lines 2154 2156 +2
============================================
+ Hits 1769 1770 +1
- Misses 385 386 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$levelreaches 0 with only one more element in the$partsarray, the next call toarray_slice($parts, 0, $level)will return an empty array. This will trigger a "undefined index" notice in the next recursion on$part = $parts[$level]. This notice gets promoted to an ErrorException in the error-handler (if the local php.ini is configured to report notices) which will cancel further processing.Fixes #695